Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to react to tiles in mapbox.style.sources #4719

Closed
archmoj opened this issue Apr 1, 2020 · 2 comments · Fixed by #4720
Closed

Fail to react to tiles in mapbox.style.sources #4719

archmoj opened this issue Apr 1, 2020 · 2 comments · Fixed by #4720
Assignees
@alexcjohnson
Labels
bug something broken

Comments

@archmoj
Copy link
Contributor

archmoj commented Apr 1, 2020

Originally reported in plotly/dash#1152.
MINIMAL DEMO
@archmoj archmoj added the bug something broken label Apr 1, 2020
@archmoj archmoj mentioned this issue Apr 1, 2020
Closed
@archmoj
Copy link
Contributor Author

archmoj commented Apr 1, 2020

Not clear what is going on here.

@archmoj
Copy link
Contributor Author

archmoj commented Apr 1, 2020

In order for the example to work, this line

plotly.js/src/plots/mapbox/mapbox.js

Line 62 in d37895b

if(self.map && (opts.accesstoken !== self.accessToken)) {

could be

if(self.map) {

So there might be a problem clearing access token for open/free maps.

@archmoj archmoj mentioned this issue Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcjohnson alexcjohnson

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

React mapbox style plotly/plotly.js
2 participants
@alexcjohnson @archmoj