Skip to content

Commit 639832c

Browse files
committed
Add file to auto-generate graph objects.
Previously, we generated these *on import*, which is slow and it’s a little sneaky. Users end up using classes that are not actually written *anywhere* in our package. Now that we only update the plot schema in version releases (no longer on import), we can also just programmatically add in all the graph obj classes. Instead of adding them to memory, we literally just print them to the file. This is some serious meta-programming… but, the resulting file will have to be syntactically valid and pass our test suite, so I’m not *too* worried about it.
1 parent 5085fa0 commit 639832c

File tree

4 files changed

+1095
-96
lines changed

4 files changed

+1095
-96
lines changed

makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ update_default_schema :
2424
json.dump(GRAPH_REFERENCE, f, indent=4, sort_keys=True,\
2525
separators=(',', ': '));\
2626
f.close()"
27+
@echo "Auto-generating graph objects based on the newly synced ."
28+
python update_graph_objs.py
2729

2830
install : sync_subs
2931
@echo ""

0 commit comments

Comments
 (0)