Skip to content

Plotly 4.2 breaks figure_factory (when scikit-image isn't installed) #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ethanopp opened this issue Oct 18, 2019 · 4 comments
Closed

Plotly 4.2 breaks figure_factory (when scikit-image isn't installed) #1829

ethanopp opened this issue Oct 18, 2019 · 4 comments

Comments

@ethanopp
Copy link

ethanopp commented Oct 18, 2019

scikit-image needs to be added to dependencies

C:\Users\OPPENE\PyCharm\Projects\fitness\venv\Scripts\python.exe C:/Users/OPPENE/PyCharm/Projects/fitness/index.py
Traceback (most recent call last):
  File "C:/Users/OPPENE/PyCharm/Projects/fitness/index.py", line 6, in <module>
    from pages import performance, home, settings, power
  File "C:\Users\OPPENE\PyCharm\Projects\fitness\pages\home.py", line 5, in <module>
    import plotly.figure_factory as ff
  File "C:\Users\OPPENE\PyCharm\Projects\fitness\venv\lib\site-packages\plotly\figure_factory\__init__.py", line 27, in <module>
    from plotly.figure_factory._ternary_contour import create_ternary_contour
  File "C:\Users\OPPENE\PyCharm\Projects\fitness\venv\lib\site-packages\plotly\figure_factory\_ternary_contour.py", line 11, in <module>
    from skimage import measure
ModuleNotFoundError: No module named 'skimage'

Process finished with exit code 1
@nicolaskruchten
Copy link
Contributor

Thanks for bringing this up, it's a regression and we'll fix it!

@nicolaskruchten nicolaskruchten changed the title Plotly 4.2 breaks figure_factory Plotly 4.2 breaks figure_factory (when scikit-image isn't installed) Oct 18, 2019
@nicolaskruchten
Copy link
Contributor

Our intention was not to have all figure factories depend on scikit-image, just the ternary contours one I believe.

The workaround for 4.2 until the fix is out is just to install the needed dependencies if you are using a figure factory.

@ethanopp
Copy link
Author

Yep that's what I did :)

@nicolaskruchten
Copy link
Contributor

Fixed in 4.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants