Initial state doesn't work in Rails 4.2 #334

kalashnikovisme · 2014-12-22T13:28:11Z

Hi, I have problem with initial state in new Rails 4.2

class User < ActiveRecord::Base
  state_machine initial: :waiting_confirmation do
    state :waiting_confirmation
    state :active
  end
end

Loading development environment (Rails 4.2.0)
[1] pry(main)> User.new.state
=> nil

Any ideas?

kalashnikovisme · 2014-12-22T13:42:17Z

I've solved problem by adding default value for state column, but it's not good.

rails g migration add_default_value_to_user_state

class AddDefaultToUserState < ActiveRecord::Migration
  def change
    change_column_default :users, :state, :waiting_confirmation
  end
end

SaKKo · 2014-12-25T09:50:17Z

I got the same problem too, i'm using this (for now)
(in your model where :draft is initial)

    after_initialize :set_initial_status
    def set_initial_status
      self.status ||= :draft
    end

aripollak · 2014-12-27T04:13:58Z

This monkey patch seems to work as an initializer, based on #335. But given that this gem seems unmaintained, I'm going to be looking for another alternative.

# Hacks around https://github.com/pluginaweek/state_machine/issues/334
module StateMachine
  module Integrations
    module ActiveRecord
      def define_state_initializer
        define_helper :instance, <<-end_eval, __FILE__, __LINE__ + 1
          def initialize(*)
            super do |*args|
              self.class.state_machines.initialize_states self
              yield(*args) if block_given?
            end
          end
        end_eval
      end
    end
  end
end

SaimonL · 2014-12-28T13:53:48Z

State machine works fine in Rails 4.1.8. When I run my seed file "rake db:drop:all db:create db:migrate db:seed --trace" in rails 4.2 is get this error:

ActiveRecord::RecordInvalid: Validation failed: State is invalid
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/validations.rb:79:in `raise_record_invalid'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/validations.rb:43:in `save!'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/attribute_methods/dirty.rb:29:in `save!'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/transactions.rb:291:in `block in save!'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/transactions.rb:347:in `block in with_transaction_returning_status'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/connection_adapters/abstract/database_statements.rb:211:in `transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/transactions.rb:220:in `transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/transactions.rb:344:in `with_transaction_returning_status'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/transactions.rb:291:in `save!'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/integrations/active_record.rb:491:in `block in save!'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/integrations/active_record.rb:506:in `block (2 levels) in around_save'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:150:in `block in run_actions'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:170:in `catch_exceptions'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:148:in `run_actions'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:133:in `run_callbacks'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:212:in `run_callbacks'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:63:in `block (2 levels) in perform'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:63:in `catch'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:63:in `block in perform'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:186:in `within_transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/transition_collection.rb:62:in `perform'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/integrations/active_record.rb:506:in `block in around_save'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/integrations/active_record.rb:534:in `block in transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/connection_adapters/abstract/database_statements.rb:213:in `block in transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/connection_adapters/abstract/transaction.rb:188:in `within_new_transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/connection_adapters/abstract/database_statements.rb:213:in `transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/transactions.rb:220:in `transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/integrations/active_record.rb:533:in `transaction'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/integrations/active_record.rb:505:in `around_save'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bundler/gems/state_machine-1a373b2d23a2/lib/state_machine/integrations/active_record.rb:491:in `save!'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fabrication-2.11.3/lib/fabrication/generator/base.rb:94:in `persist'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fabrication-2.11.3/lib/fabrication/generator/base.rb:26:in `create'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fabrication-2.11.3/lib/fabrication/schematic/definition.rb:75:in `block in fabricate'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fabrication-2.11.3/lib/fabrication/schematic/definition.rb:74:in `instance_eval'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fabrication-2.11.3/lib/fabrication/schematic/definition.rb:74:in `fabricate'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fabrication-2.11.3/lib/fabricate.rb:29:in `create'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fabrication-2.11.3/lib/fabrication.rb:62:in `Fabricate'
/repos/derail/db/seeds.rb:12:in `'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activesupport-4.2.0/lib/active_support/dependencies.rb:268:in `load'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activesupport-4.2.0/lib/active_support/dependencies.rb:268:in `block in load'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activesupport-4.2.0/lib/active_support/dependencies.rb:240:in `load_dependency'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activesupport-4.2.0/lib/active_support/dependencies.rb:268:in `load'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/railties-4.2.0/lib/rails/engine.rb:547:in `load_seed'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/tasks/database_tasks.rb:250:in `load_seed'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.2.0/lib/active_record/railties/databases.rake:180:in `block (2 levels) in '
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:240:in `call'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:240:in `block in execute'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:235:in `each'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:235:in `execute'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:172:in `invoke_with_call_chain'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:165:in `invoke'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:150:in `invoke_task'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `block (2 levels) in top_level'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `each'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `block in top_level'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:115:in `run_with_threads'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:100:in `top_level'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:78:in `block in run'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:176:in `standard_exception_handling'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:75:in `run'
/home/saimon/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/bin/rake:33:in `'
/home/saimon/.rbenv/versions/2.1.5/bin/rake:23:in `load'
/home/saimon/.rbenv/versions/2.1.5/bin/rake:23:in `'
Tasks: TOP => db:seed

I installed state machine via Gemfile:

gem 'state_machine', git: 'https://github.com/seuros/state_machine.git'

The code where this happens:

  repo = Fabricate(:repo, project: project, server_url: 'CustomLogger',  server_type: 'GitHub')

Fabricate is same as FactoryGirl.create(:repo, ...)
The validation only looks for presence of project, server_url, and server_type.

Repo is an AcriveRecord Model which has this state code:

 state_machine :state, initial: :ready do
    state :retrieved
    state :pulled
    state :removed
    event :retrieve do
      transition ready: :retrieved
      transition removed: :retrieved
    end
    event :pull do
      transition retrieved: :pulled
      transition pulled: :pulled
      transition compleated: :pulled
    end
    event :remove do
      transition retrieved: :removed
      transition pulled: :removed
      transition compleated: :removed
    end
  end

nfedyashev · 2014-12-31T10:13:48Z

@SaKKo @kalashnikovisme thanks for posting workarounds!

xinuc · 2015-01-09T07:28:09Z

confirmed this issue.

d0minicw0ng · 2015-01-09T09:06:29Z

+1

Mehonoshin · 2015-01-10T17:48:31Z

If the gem is not maintained anymore, maybe someone wants to maintain its fork?

nfedyashev · 2015-01-11T13:14:47Z

@Mehonoshin #310

advantgroup · 2015-02-11T07:30:39Z

@SaimonL +1
Exactly the same problem. Find a fix?

lucascaton · 2015-02-17T04:25:42Z

@pluginaweek any news on this? Thanks.

rusterholz · 2015-02-17T17:30:08Z

Guys, @seuros maintains a fork of this which does not exhibit this issue when used with Rails 4.2. See discussion here: #310

SaimonL · 2015-02-26T20:01:24Z

The solution is you have to set default state in the database level.
so the migration file will look like this:

t.string :status, default: 'start'

Having the state nil will cause error. Don't know about the updated versions.

jakehockey10 · 2015-03-21T18:59:44Z

This worked for me in development, but not in production on Heroku.

seuros · 2015-03-21T19:02:32Z

Guys, just use state_machines-activerecord.

kalashnikovisme · 2015-03-23T00:44:24Z

I use https://github.com/seuros/state_machine with Rails 4.2

everything work now

seuros · 2015-03-23T07:34:42Z

@kalashnikovisme https://github.com/state-machines/state_machines-activerecord

shlima · 2015-04-22T10:33:17Z

+1

khaleksa · 2015-04-27T09:53:10Z

+1

mkonikowski · 2015-05-04T14:29:54Z

+1

styx · 2015-05-06T07:23:07Z

@mkonikowski @shlima @khaleksa
This repo is not supported. Development moved to:
https://github.com/state-machines/state_machines-activerecord

mkonikowski · 2015-05-07T08:17:31Z

@styx I've discovered it already, but forgot to comment here... Maybe in the Readme you could add info that this repo is not maintained anymore and put a link to state_machines-activerecord as the most recent one?

seuros · 2015-05-07T09:10:03Z

@mkonikowski Nobody has access to this repo anymore. That why we have the other one :)

scrooloose · 2015-05-13T16:07:59Z

@seuros - thanks, I am now using state_machines-activerecord

klebervirgilio · 2015-10-27T22:05:39Z

+1

dosire · 2015-11-08T22:25:38Z

MR with fix https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1764

fly1tkg mentioned this issue Dec 25, 2014

fix issue initial state doesn't work in active_record 4.2 #335

Open

dwilkie mentioned this issue Jan 26, 2015

Replace state machine gem dwilkie/chibi#108

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial state doesn't work in Rails 4.2 #334

Initial state doesn't work in Rails 4.2 #334

kalashnikovisme commented Dec 22, 2014

kalashnikovisme commented Dec 22, 2014

SaKKo commented Dec 25, 2014

aripollak commented Dec 27, 2014

SaimonL commented Dec 28, 2014

nfedyashev commented Dec 31, 2014

xinuc commented Jan 9, 2015

d0minicw0ng commented Jan 9, 2015

Mehonoshin commented Jan 10, 2015

nfedyashev commented Jan 11, 2015

advantgroup commented Feb 11, 2015

lucascaton commented Feb 17, 2015

rusterholz commented Feb 17, 2015

SaimonL commented Feb 26, 2015

jakehockey10 commented Mar 21, 2015

seuros commented Mar 21, 2015

kalashnikovisme commented Mar 23, 2015

seuros commented Mar 23, 2015

shlima commented Apr 22, 2015

khaleksa commented Apr 27, 2015

mkonikowski commented May 4, 2015

styx commented May 6, 2015

mkonikowski commented May 7, 2015

seuros commented May 7, 2015

scrooloose commented May 13, 2015

klebervirgilio commented Oct 27, 2015

dosire commented Nov 8, 2015

Initial state doesn't work in Rails 4.2 #334

Initial state doesn't work in Rails 4.2 #334

Comments

kalashnikovisme commented Dec 22, 2014

kalashnikovisme commented Dec 22, 2014

SaKKo commented Dec 25, 2014

aripollak commented Dec 27, 2014

SaimonL commented Dec 28, 2014

nfedyashev commented Dec 31, 2014

xinuc commented Jan 9, 2015

d0minicw0ng commented Jan 9, 2015

Mehonoshin commented Jan 10, 2015

nfedyashev commented Jan 11, 2015

advantgroup commented Feb 11, 2015

lucascaton commented Feb 17, 2015

rusterholz commented Feb 17, 2015

SaimonL commented Feb 26, 2015

jakehockey10 commented Mar 21, 2015

seuros commented Mar 21, 2015

kalashnikovisme commented Mar 23, 2015

seuros commented Mar 23, 2015

shlima commented Apr 22, 2015

khaleksa commented Apr 27, 2015

mkonikowski commented May 4, 2015

styx commented May 6, 2015

mkonikowski commented May 7, 2015

seuros commented May 7, 2015

scrooloose commented May 13, 2015

klebervirgilio commented Oct 27, 2015

dosire commented Nov 8, 2015