Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode missing for ActionDateTimePicker #108

Closed
FlashThePlayer opened this issue Oct 5, 2023 · 1 comment · Fixed by #109
Closed

Mode missing for ActionDateTimePicker #108

FlashThePlayer opened this issue Oct 5, 2023 · 1 comment · Fixed by #109

Comments

@FlashThePlayer
Copy link
Contributor

Hi,
I do think the mode property for the ActionDateTimePicker component is missing?
Under admin/src/components/Action/Action.js the ActionTimePicker is build like

<ActionTimePicker onChange={handleDateChange} executeAt={executeAt} isCreating={isCreating} isEditing={isEditing} />

But i guess it should be

<ActionTimePicker onChange={handleDateChange} executeAt={executeAt} isCreating={isCreating} isEditing={isEditing} mode={mode} />

Without the mode attribute the header of the date picker looks like this
Screenshot 2023-10-05 at 11 55 13

With the attribute set I get the corrcet display
Screenshot 2023-10-05 at 11 54 07

Also how do you like feature requests?
I currently the date format is not changeable?
Is it possible that you could add a locale attribute to the settings like the same way you do step?
Or is a pull request better for a request like this?

Anyway thx for the plugin, it makes live way easier!

@ComfortablyCoding
Copy link
Contributor

Thanks for the report!

That looks to be the case, not sure how that got through :)

In terms of feature requests a PR over an issue is fine. PRs are always welcome.

If you end up doing a PR for both of the mentioned things I would prefer they each be done in their own PRs. I try to keep it to one PR per bug/feature etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants