fix(ldapselectfield): use of uninitialized var

pluginsGLPI · Apr 20, 2022 · 376e210 · 376e210
1 parent 536edbf
commit 376e210
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/tests/4-functional/Glpi/Plugin/Formcreator/Field/LdapSelectField.php b/tests/4-functional/Glpi/Plugin/Formcreator/Field/LdapSelectField.php
@@ -73,6 +73,7 @@ public function testCreateForm() {
       $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] select[name="show_empty"]');
       $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] input[name="ldap_filter"]');
       $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] select[name="ldap_attribute"]');
+      $this->client->waitForVisibility('form[data-itemtype="PluginFormcreatorQuestion"] select[name="ldap_auth"]');
 
       $authLdap = new \AuthLDAP();
       $ldaps = $authLdap->find([], [], 1);

diff --git a/tests/src/CommonBrowsing.php b/tests/src/CommonBrowsing.php
@@ -101,10 +101,11 @@ public function selectInDropdown($selector, $value, $name = '') {
          var exists = $('$slashSelector option[value=\"$htmlValue\"]');
          if (exists.length < 1) {
             var newOption = new Option('$slashName', '$slashValue', true, true);
+            $('$slashSelector').append(newOption)
          } else {
             $('$slashSelector').val('$slashValue');
          }
-         $('$slashSelector').append(newOption).trigger('change');
+         $('$slashSelector').trigger('change');
       ";
       $this->test->client->executeScript($js);
    }