fix(install): fresh installation does not saves current schema version

see #794
pluginsGLPI · Oct 24, 2017 · 8eadd7d · 8eadd7d
1 parent 86893f4
commit 8eadd7d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/install/install.php b/install/install.php
@@ -21,6 +21,8 @@ public function install(Migration $migration) {
       $this->createDefaultDisplayPreferences();
       $this->createNotifications();
 
+      Config::setConfigurationValues('formcreator', ['schema_version' => PLUGIN_FORMCREATOR_SCHEMA_VERSION]);
+
       return true;
    }
 
@@ -371,10 +373,13 @@ protected function deleteTicketRelation() {
       PluginFormcreatorCommon::setNotification($use_mailing);
    }
 
+   /**
+    * Cleanups the database from plugin's itemtypes (tables and relations)
+    */
    protected function deleteTables() {
       global $DB;
 
-      // Drop tables
+      // Keep  these itemtypes as string because classes might be not avaiable (if plugin is inactive)
       $itemtypes = [
          'PluginFormcreatorAnswer',
          'PluginFormcreatorCategory',

diff --git a/tests/0000_Install/PluginInstallTest.php b/tests/0000_Install/PluginInstallTest.php
@@ -84,6 +84,10 @@ public function testInstallPlugin() {
       $PluginDBTest = new PluginDB();
       $PluginDBTest->checkInstall("formcreator", "install");
 
+      $config = Config::getConfigurationValues('formcreator');
+      $this->assertArrayHasKey('schema_version', $config);
+      $this->assertEquals($config['schema_version'], PLUGIN_FORMCREATOR_SCHEMA_VERSION);
+
       // Enable the plugin
       $plugin->activate($plugin->fields['id']);
       $this->assertTrue($plugin->isActivated("formcreator"), "Cannot enable the plugin");

diff --git a/tests/9000_Uninstall/PluginUninstallTest.php b/tests/9000_Uninstall/PluginUninstallTest.php
@@ -64,7 +64,10 @@ public function testUninstall() {
       $rows = $template->find("`itemtype` = 'PluginFormcreatorForm_Answer'");
       $this->assertCount(0, $rows);
 
-      // TODO: need to find a r eliable way to detect not clenaed
+      $config = Config::getConfigurationValues('formcreator');
+      $this->assertArrayNotHasKey('schema_version', $config);
+
+      // TODO: need to find a reliable way to detect not clenaed
       // - NotificationTemplateTranslation
       // - Notification_NotificationTemplate
    }