Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms View shows all items from Knowledge Base #3011

Open
carlosbmc opened this issue Oct 3, 2022 · 6 comments
Open

Forms View shows all items from Knowledge Base #3011

carlosbmc opened this issue Oct 3, 2022 · 6 comments

Comments

@carlosbmc
Copy link

carlosbmc commented Oct 3, 2022

Hello

using GLPI_VERSION: 10.0.2 + FORMCREATOR 2.13.0

Forms View shows all items from Knowledge Base.

We have a lot of Knowledge Base Items with targest goups or entities. But

all users can see these Knowledge Base Items in search (but can access when click. "You do not have permissions to perform this action").

This not occurs in previos versios <2.13 of th plugin

It is possible to hide these items for which you do not have permission?

Thank you!..

@btry
Copy link
Collaborator

btry commented Oct 3, 2022

Hi

I think the problem is in GLPI. Can you try this patch and tell if it solves the problem ?

glpi-project/glpi#11923

@carlosbmc
Copy link
Author

Thak you.

but I don't find this OR clause in this file
knowbaseitem.class.zip

@btry
Copy link
Collaborator

btry commented Oct 3, 2022

Your file seems to not the same as what I have in a recent revision of GLPI 10. You probably have applied some patch near the line to remove.

Here is the state of the file in the repository of GLPI (branch 10.0/bugfixes):
https://github.com/glpi-project/glpi/blob/10.0/bugfixes/src/KnowbaseItem.php#L623

Also, to apply a patch you must use the patch tool. Avoid to do it manually.

As I don't know anything about the modifications of your instance I can't help further. you should handle that with the persons who did those modifications.

@carlosbmc
Copy link
Author

Hello,

I'm searching in inc/knowbiseitem.class.php as refer in glpi-project/glpi#11923,

but the clausule is in KnowbaseItem.php as you say.

Thank you!!

@btry
Copy link
Collaborator

btry commented Oct 3, 2022

If you use GLPI 10 you should no longer have .class.php files in inc/ (except a few ones). There is maybe something wrong in your instance.

@carlosbmc
Copy link
Author

May be older files before some upgrades.
I will ty to remove it
Than you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants