fix(question): better error handling

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Feb 4, 2021 · 051184a · 051184a
1 parent b99b19b
commit 051184a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/ajax/question_add.php b/ajax/question_add.php
@@ -41,9 +41,7 @@
 }
 
 if (!$question->add($_REQUEST)) {
-    http_response_code(500);
-    echo array_shift($_SESSION['MESSAGE_AFTER_REDIRECT'][ERROR]);
-    unset($_SESSION['MESSAGE_AFTER_REDIRECT'][ERROR]);
+    http_response_code(400);
     exit;
 }
 $json = [

diff --git a/js/scripts.js.php b/js/scripts.js.php
@@ -817,13 +817,9 @@ function buildTiles(list) {
          data: form.serializeArray(),
          dataType: 'json'
       }).fail(function(data) {
-         // Closing and opening the modal workarounds
-         // the whole modal being disabled when alert is shown
-         // modalWindow.dialog('close');
-         // alert(data.responseText);
-         // modalWindow.dialog('open');
-         $('#plugin_formcreator_error').text(data.responseText);
-         $('#plugin_formcreator_error').show();
+         // fix for GLPI <= 9.5.2
+         $('[id^="message_after_redirect_"]').remove();
+         displayAjaxMessageAfterRedirect();
       }).done(function(data) {
          var sectionId = form.find('select[name="plugin_formcreator_sections_id"]').val();
          var container = $('[data-itemtype="PluginFormcreatorSection"][data-id="' + sectionId + '"] .grid-stack');