fix: various fixes on duplicate / import

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

Author: btry

inc/item_targetticket.class.php

@@ -182,7 +182,6 @@ protected function convertUuids(&$parameter) {
    public function deleteObsoleteItems(CommonDBTM $container, array $exclude)
    {
       $keepCriteria = [
-         self::$itemtype_2 => $container->getType(),
          self::$items_id_2 => $container->getID(),
       ];
       if (count($exclude) > 0) {

inc/question.class.php

@@ -587,15 +587,15 @@ public function pre_deleteItem() {
    public function post_addItem() {
       if (!isset($this->input['_skip_checks']) || !$this->input['_skip_checks']) {
          $this->updateConditions($this->input);
+         $this->updateParameters($this->input);
       }
-      $this->updateParameters($this->input);
    }
 
    public function post_updateItem($history = 1) {
       if (!isset($this->input['_skip_checks']) || !$this->input['_skip_checks']) {
          $this->updateConditions($this->input);
+         $this->updateParameters($this->input);
       }
-      $this->updateParameters($this->input);
    }
 
    /**

inc/questionparameter.class.php

@@ -84,7 +84,7 @@ public function prepareInputforAdd($input) {
    public function deleteObsoleteItems(CommonDBTM $container, array $exclude)
    {
       $keepCriteria = [
-         self::$items_id => $container->getID(),
+         static::$items_id => $container->getID(),
       ];
       if (count($exclude) > 0) {
          $keepCriteria[] = ['NOT' => ['id' => $exclude]];

inc/target_actor.class.php

@@ -235,7 +235,7 @@ public function export($remove_uuid = false) {
    public function deleteObsoleteItems(CommonDBTM $container, array $exclude)
    {
       $keepCriteria = [
-         self::$items_id => $container->getID(),
+         static::$items_id => $container->getID(),
       ];
       if (count($exclude) > 0) {
          $keepCriteria[] = ['NOT' => ['id' => $exclude]];

inc/targetchange.class.php

@@ -651,7 +651,6 @@ public function getTargetChangesForForm($formId) {
          'WHERE'  => [
             'plugin_formcreator_forms_id' => $formId
          ],
-         'ORDER'  => 'order ASC'
       ]);
       foreach ($rows as $row) {
          $target = new self();

inc/targetticket.class.php

@@ -1225,7 +1225,6 @@ public function getTargetTicketsForForm($formId) {
          'WHERE'  => [
             'plugin_formcreator_forms_id' => $formId
          ],
-         'ORDER'  => 'order ASC'
       ]);
       foreach ($rows as $row) {
          $target = new self();