fix(question): save images in description as inline base64

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Aug 9, 2021 · 21b94f5 · 21b94f5
1 parent 906ebeb
commit 21b94f5
Show file tree

Hide file tree

Showing 2 changed files with 66 additions and 2 deletions.
diff --git a/inc/abstractfield.class.php b/inc/abstractfield.class.php
@@ -88,7 +88,15 @@ public function show($domain, $canEdit = true) {
          $html .= '</label>';
       }
       if ($this->isEditableField() && !empty($this->question->fields['description'])) {
-         $html .= '<div class="help-block">' . html_entity_decode(__($this->question->fields['description'], $domain)) . '</div>';
+         $description = $this->question->fields['description'];
+         foreach (PluginFormcreatorCommon::getDocumentsFromTag($description) as $document) {
+            $prefix = uniqid('', true);
+            $filename = $prefix . 'image_paste.' . pathinfo($document['filename'], PATHINFO_EXTENSION);
+            if (!copy(GLPI_DOC_DIR . '/' . $document['filepath'], GLPI_TMP_DIR . '/' . $filename)) {
+               continue;
+            }
+         }
+         $html .= '<div class="help-block">' . html_entity_decode(__($description, $domain)) . '</div>';
       }
       $html .= '<div class="form_field">';
       $html .= $this->getRenderedHtml($domain, $canEdit);

diff --git a/inc/question.class.php b/inc/question.class.php
@@ -440,6 +440,34 @@ public function prepareInputForAdd($input) {
          }
       }
 
+      // handle description field and its inline pictures
+      if (isset($input['_description'])) {
+         foreach ($input['_description'] as $id => $filename) {
+            // TODO :replace PluginFormcreatorCommon::getDuplicateOf by Document::getDuplicateOf
+            // when is merged https://github.com/glpi-project/glpi/pull/9335
+            if ($document = PluginFormcreatorCommon::getDuplicateOf(Session::getActiveEntity(), GLPI_TMP_DIR . '/' . $filename)) {
+               $this->value = str_replace('id="' .  $input['_tag_description'] . '"', $document->fields['tag'], $this->value);
+               $input['_tag_description'][$id] = $document->fields['tag'];
+            }
+         }
+
+         $input = $this->addFiles(
+            $input,
+            [
+               'force_update'  => true,
+               'content_field' => null,
+               'name'          => 'description',
+            ]
+         );
+
+         $input['description'] = Html::entity_decode_deep($input['description']);
+         foreach ($input['_tag_description'] as $tag) {
+            $regex = '/<img[^>]+' . preg_quote($tag, '/') . '[^<]+>/im';
+            $input['description'] = preg_replace($regex, "#$tag#", $input['description']);
+         }
+         $input['description'] = Html::entities_deep($input['description']);
+      }
+
       // generate a unique id
       if (!isset($input['uuid'])
           || empty($input['uuid'])) {
@@ -469,6 +497,34 @@ public function prepareInputForUpdate($input) {
          return false;
       }
 
+      // handle description field and its inline pictures
+      if (isset($input['_description'])) {
+         foreach ($input['_description'] as $id => $filename) {
+            // TODO :replace PluginFormcreatorCommon::getDuplicateOf by Document::getDuplicateOf
+            // when is merged https://github.com/glpi-project/glpi/pull/9335
+            if ($document = PluginFormcreatorCommon::getDuplicateOf(Session::getActiveEntity(), GLPI_TMP_DIR . '/' . $filename)) {
+               $this->value = str_replace('id="' .  $input['_tag_description'] . '"', $document->fields['tag'], $this->value);
+               $input['_tag_description'][$id] = $document->fields['tag'];
+            }
+         }
+
+         $input = $this->addFiles(
+            $input,
+            [
+               'force_update'  => true,
+               'content_field' => null,
+               'name'          => 'description',
+            ]
+         );
+
+         $input['description'] = Html::entity_decode_deep($input['description']);
+         foreach ($input['_tag_description'] as $tag) {
+            $regex = '/<img[^>]+' . preg_quote($tag, '/') . '[^<]+>/im';
+            $input['description'] = preg_replace($regex, "#$tag#", $input['description']);
+         }
+         $input['description'] = Html::entities_deep($input['description']);
+      }
+
       // generate a unique id
       if (!isset($input['uuid'])
           || empty($input['uuid'])) {
@@ -831,7 +887,7 @@ public function showForm($ID, $options = []) {
       echo Html::textarea([
          'name'    => 'description',
          'id'      => 'description',
-         'value'   => $this->fields['description'],
+         'value'   => Toolbox::convertTagToImage($this->fields['description'], $this),
          'enable_richtext' => true,
          'filecontainer'   => 'description_info',
          'display' => false,