fix(filefield): documentt upload with GLPI 9.5

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Jul 13, 2020 · 2b48e82 · 2b48e82
1 parent 108984b
commit 2b48e82
Show file tree

Hide file tree

Showing 21 changed files with 63 additions and 20 deletions.
diff --git a/inc/fieldinterface.class.php b/inc/fieldinterface.class.php
@@ -107,6 +107,11 @@ public function getValueForDesign();
     */
    public function getValueForTargetText($richText);
 
+   /**
+    * Move uploaded files and make Document items
+    */
+   public function moveUploads();
+
    /**
     * Gets the documents IDs
     *

diff --git a/inc/fields/actorfield.class.php b/inc/fields/actorfield.class.php
@@ -205,6 +205,7 @@ public function getValueForTargetText($richText) {
       return $value;
    }
 
+   public function moveUploads() {}
 
    public function getDocumentsForTarget() {
       return [];

diff --git a/inc/fields/checkboxesfield.class.php b/inc/fields/checkboxesfield.class.php
@@ -287,6 +287,8 @@ public function getValueForTargetText($richText) {
       return $value;
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/datefield.class.php b/inc/fields/datefield.class.php
@@ -113,6 +113,8 @@ public function hasInput($input) {
       return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/datetimefield.class.php b/inc/fields/datetimefield.class.php
@@ -116,6 +116,8 @@ public function getValueForTargetText($richText) {
       return Toolbox::addslashes_deep(Html::convDateTime($this->value));
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];;
    }

diff --git a/inc/fields/descriptionfield.class.php b/inc/fields/descriptionfield.class.php
@@ -68,6 +68,8 @@ public function getValueForTargetText($richText) {
       return '';
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/dropdownfield.class.php b/inc/fields/dropdownfield.class.php
@@ -346,6 +346,8 @@ public function getValueForTargetText($richText) {
       return $value;
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/emailfield.class.php b/inc/fields/emailfield.class.php
@@ -87,6 +87,8 @@ public function getRenderedHtml($canEdit = true) {
       return $html;
    }
 
+   public function moveUploads() {}
+
    public function isValidValue($value) {
       if ($value === '') {
          return true;

diff --git a/inc/fields/filefield.class.php b/inc/fields/filefield.class.php
@@ -92,6 +92,25 @@ public function getValueForTargetText($richText) {
       return $this->value;
    }
 
+   public function moveUploads()
+   {
+      $key = 'formcreator_field_' . $this->question->getID();
+      if (!is_array($this->uploads) || !isset($this->uploads["_$key"])) {
+         return;
+      }
+      $answer_value = [];
+      $index = 0;
+      foreach ($this->uploads["_$key"] as $document) {
+         $document = Toolbox::stripslashes_deep($document);
+         if (is_file(GLPI_TMP_DIR . '/' . $document)) {
+            $prefix = $this->uploads['_prefix_formcreator_field_' . $this->question->getID()][$index];
+            $answer_value[] = $this->saveDocument($document, $prefix);
+         }
+         $index++;
+      }
+      $this->uploadData = $answer_value;
+   }
+
    public function getDocumentsForTarget() {
       return $this->uploadData;
    }
@@ -215,26 +234,6 @@ public function parseAnswerValues($input, $nonDestructive = false) {
             return false;
          }
 
-         if (PLUGIN_FORMCREATOR_TEXTAREA_FIX && version_compare(GLPI_VERSION, '9.5.0-dev') < 0) {
-            $answer_value = [];
-            $index = 0;
-            if ($nonDestructive) {
-               $index = count($input["_$key"]);
-            } else {
-               foreach ($input["_$key"] as $document) {
-                  $document = Toolbox::stripslashes_deep($document);
-                  if (is_file(GLPI_TMP_DIR . '/' . $document)) {
-                     $prefix = $input['_prefix_formcreator_field_' . $this->question->getID()][$index];
-                     $answer_value[] = $this->saveDocument($document, $prefix);
-                  }
-                  $index++;
-               }
-            }
-            $this->uploadData = $answer_value;
-            $this->value = __('Attached document', 'formcreator');
-
-            return true;
-         }
          if ($this->hasInput($input)) {
             $this->value = __('Attached document', 'formcreator');
          }

diff --git a/inc/fields/floatfield.class.php b/inc/fields/floatfield.class.php
@@ -118,6 +118,8 @@ public function getValueForTargetText($richText) {
       return Toolbox::addslashes_deep($this->value);
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/hiddenfield.class.php b/inc/fields/hiddenfield.class.php
@@ -111,6 +111,8 @@ public function hasInput($input) {
       return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/hostnamefield.class.php b/inc/fields/hostnamefield.class.php
@@ -58,6 +58,8 @@ public function hasInput($input) {
       return false;
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/integerfield.class.php b/inc/fields/integerfield.class.php
@@ -39,6 +39,8 @@ public function serializeValue() {
       return strval((int) $this->value);
    }
 
+   public function moveUploads() {}
+
    public function isValidValue($value) {
       if (strlen($value) == 0) {
          return true;

diff --git a/inc/fields/ipfield.class.php b/inc/fields/ipfield.class.php
@@ -91,6 +91,8 @@ public function getValueForTargetText($richText) {
       return Toolbox::addslashes_deep($this->value);
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/multiselectfield.class.php b/inc/fields/multiselectfield.class.php
@@ -66,6 +66,8 @@ public function hasInput($input) {
       return isset($input['formcreator_field_' . $this->question->getID()]);
    }
 
+   public function moveUploads() {}
+
    public static function getName() {
       return __('Multiselect', 'formcreator');
    }

diff --git a/inc/fields/radiosfield.class.php b/inc/fields/radiosfield.class.php
@@ -209,6 +209,8 @@ public function getValueForTargetText($richText) {
       return $this->value;
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/requesttypefield.class.php b/inc/fields/requesttypefield.class.php
@@ -156,6 +156,8 @@ public function getValueForTargetText($richText) {
       return $available[$this->value];
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/textfield.class.php b/inc/fields/textfield.class.php
@@ -123,6 +123,8 @@ public function getValueForTargetText($richText) {
       return Toolbox::addslashes_deep($this->value);
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/timefield.class.php b/inc/fields/timefield.class.php
@@ -131,6 +131,8 @@ public function getValueForTargetText($richText) {
       return Toolbox::addslashes_deep($date->format('H:i'));
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/fields/urgencyfield.class.php b/inc/fields/urgencyfield.class.php
@@ -168,6 +168,8 @@ public function getValueForTargetText($richText) {
       return $available[$this->value];
    }
 
+   public function moveUploads() {}
+
    public function getDocumentsForTarget() {
       return [];
    }

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
@@ -49,7 +49,9 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
    const STATUS_REFUSED = 102;
    const STATUS_ACCEPTED = 103;
 
+   /** @var $questionFields PluginFormcreatorField[] fields of the form answers */
    private $questionFields = [];
+
    private $questions      = [];
 
    public static function getStatuses() {
@@ -1091,7 +1093,9 @@ public function getFullForm($richText = false) {
 
    public function post_addItem() {
       // Save questions answers
+      /** @var PluginFormcreatorField $field */
       foreach ($this->questionFields as $questionId => $field) {
+         $field->moveUploads();
          $answer = new PluginFormcreatorAnswer();
          $answer->add([
             'plugin_formcreator_formanswers_id'  => $this->getID(),