fix(targetchange): do not geenrate HTML for simple text fields

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Jul 30, 2020 · 2d7a5f6 · 2d7a5f6
1 parent f6e09f0
commit 2d7a5f6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/inc/fields/textareafield.class.php b/inc/fields/textareafield.class.php
@@ -184,7 +184,12 @@ public function parseAnswerValues($input, $nonDestructive = false) {
    }
 
    public function getValueForTargetText($richText) {
-      return $this->value;
+      $value = $this->value;
+      if (!$richText) {
+         $value = Toolbox::unclean_cross_side_scripting_deep($value);
+         $value = strip_tags($value);
+      }
+      return $value;
    }
 
    public function equals($value) {

diff --git a/inc/targetchange.class.php b/inc/targetchange.class.php
@@ -608,10 +608,10 @@ public function save(PluginFormcreatorFormAnswer $formanswer) {
          $data[$changeField] = $this->prepareTemplate(
             $this->fields[$changeField],
             $formanswer,
-            true
+            $changeField == 'content' // only content supports rich text
          );
 
-         $data[$changeField] = $formanswer->parseTags($data[$changeField], $this);
+         $data[$changeField] = $formanswer->parseTags($data[$changeField], $this, $changeField == 'content');
       }
 
       $data['_users_id_recipient']   = $_SESSION['glpiID'];