fix(form): duplicate empty form

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Apr 14, 2020 · 5944935 · 5944935
1 parent 4969884
commit 5944935
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/inc/form.class.php b/inc/form.class.php
@@ -2002,13 +2002,15 @@ public static function import(PluginFormcreatorLinker $linker, $input = [], $con
             $importedItems[] = $importedItem;
          }
          // Delete all other restrictions
+         $deleteCriteria = [];
          if (count($importedItems) > 0) {
-            $FormProfile = new PluginFormcreatorForm_Profile();
-            $FormProfile->deleteByCriteria([
-               $formFk => $itemId,
-               ['NOT' => ['id' => $importedItems]]
-            ]);
+            $deleteCriteria = ['NOT' => ['id' => $importedItems]];
          }
+         $FormProfile = new PluginFormcreatorSection();
+         $FormProfile->deleteByCriteria([
+            $formFk => $itemId,
+            $deleteCriteria,
+         ]);
       }
 
       // import form's sections
@@ -2036,11 +2038,13 @@ public static function import(PluginFormcreatorLinker $linker, $input = [], $con
             $importedItems[] = $importedItem;
          }
          // Delete all other restrictions
-         $FormProfile = new PluginFormcreatorSection();
-         $FormProfile->deleteByCriteria([
-            $formFk => $itemId,
-            ['NOT' => ['id' => $importedItems]]
-         ]);
+         if (count($importedItems) > 0) {
+            $FormProfile = new PluginFormcreatorSection();
+            $FormProfile->deleteByCriteria([
+               $formFk => $itemId,
+               ['NOT' => ['id' => $importedItems]]
+            ]);
+         }
       }
 
       // import form's targets