fix(radiosfield): better overlap prevention

when labels needs several lines to show Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Feb 5, 2020 · a2f1ed1 · a2f1ed1
1 parent 8f57d8d
commit a2f1ed1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/css/styles.css b/css/styles.css
@@ -345,7 +345,7 @@ form.formcreator_form {
    cursor: pointer;
    padding-left: 22px;
    position: relative;
-   display: block;
+   display: inline-block;
    height: 26px;
 }
 .formcreator_radios input[type = radio] + label:before,

diff --git a/inc/fields/radiosfield.class.php b/inc/fields/radiosfield.class.php
@@ -92,10 +92,6 @@ public function displayField($canEdit = true) {
          $rand         = mt_rand();
          $fieldName    = 'formcreator_field_' . $id;
          $domId        = $fieldName . '_' . $rand;
-         // echo '<input type="hidden" class="form-control"
-         //    name="' . $fieldName . '"
-         //    id="' . $domId . '"
-         //    value="" />' . PHP_EOL;
 
          $values = $this->getAvailableValues();
          if (!empty($values)) {
@@ -105,15 +101,15 @@ public function displayField($canEdit = true) {
                if ((trim($value) != '')) {
                   $i++;
                   $checked = ($this->value == $value) ? ' checked' : '';
+                  echo '<p>';
                   echo '<input type="radio" class="form-control"
                         name="' . $fieldName . '"
                         id="' . $domId . '_' . $i . '"
                         value="' . $value . '"' . $checked . ' /> ';
                   echo '<label for="' . $domId . '_' . $i . '">';
                   echo $value;
                   echo '</label>';
-                  echo '<br/>';
-                  echo '<br/>';
+                  echo '</p>';
                }
             }
             echo '</div>';