fix(filefield): fix bad value in generated targets

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Mar 13, 2019 · d3aeb0d · d3aeb0d
1 parent 575dbf8
commit d3aeb0d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/inc/fields/filefield.class.php b/inc/fields/filefield.class.php
@@ -71,10 +71,9 @@ public function deserializeValue($value) {
       if ($this->uploadData === null) {
          $this->uploadData = [];
       }
-      if (count($this->uploadData) === 0) {
+      $this->value = __('No attached document', 'formcreator');;
+      if (count($this->uploadData) > 0) {
          $this->value = __('Attached document', 'formcreator');
-      } else {
-         $this->value = '';
       }
    }
 

diff --git a/tests/suite-unit/PluginFormcreatorFileField.php b/tests/suite-unit/PluginFormcreatorFileField.php
@@ -39,4 +39,23 @@ public function testIsPrerequisites() {
       $output = $instance->isPrerequisites();
       $this->boolean($output)->isEqualTo(true);
    }
+
+   public function testDeserializeValue() {
+      $instance = $this->newTestedInstance([]);
+      $instance->deserializeValue('invalid Json');
+      $this->string($instance->getValueForTargetText(true))
+         ->isEqualTo('No attached document');
+
+      $instance->deserializeValue('[]');
+      $this->string($instance->getValueForTargetText(true))
+         ->isEqualTo('No attached document');
+
+      $instance->deserializeValue('[1]');
+      $this->string($instance->getValueForTargetText(true))
+         ->isEqualTo('Attached document');
+
+      $instance->deserializeValue('[1,2]');
+      $this->string($instance->getValueForTargetText(true))
+         ->isEqualTo('Attached document');
+   }
 }