fix(question): show error toast when editing a question fails

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Nov 29, 2021 · d90c3f9 · d90c3f9
1 parent d81b763
commit d90c3f9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/ajax/question_update.php b/ajax/question_update.php
@@ -54,8 +54,6 @@
 
 $success = $question->update($_REQUEST);
 if (!$success) {
-    echo array_shift($_SESSION['MESSAGE_AFTER_REDIRECT'][ERROR]);
-    unset($_SESSION['MESSAGE_AFTER_REDIRECT'][ERROR]);
     http_response_code(500);
     exit();
 }

diff --git a/js/scripts.js b/js/scripts.js
@@ -836,8 +836,7 @@ var plugin_formcreator = new function() {
          data: form.serializeArray(),
          dataType: 'html'
       }).fail(function(data) {
-         $('#plugin_formcreator_error').text(data.responseText);
-         $('#plugin_formcreator_error').show();
+         displayAjaxMessageAfterRedirect();
       }).done(function(data) {
          var question = $('.plugin_formcreator_form_design[data-itemtype="PluginFormcreatorForm"] [data-itemtype="PluginFormcreatorQuestion"][data-id="' + questionId + '"]');
          question.find('[data-field="name"]').text(data)