fix(question): prevent bad request

may try to load a itemtype represented by a class named '0' Signed-off-by: Thierry Bugier <tbugier@teclib.com>
pluginsGLPI · Jan 28, 2021 · ea66d63 · ea66d63
1 parent d6adbbf
commit ea66d63
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ajax/commontree.php b/ajax/commontree.php
@@ -42,7 +42,7 @@
 $depth    = $_GET['maxDepth'];
 
 // This should only be used for dropdowns
-if (!is_a($itemtype, CommonTreeDropdown::class, true)) {
+if ((int) $itemtype == $itemtype || !is_a($itemtype, CommonTreeDropdown::class, true)) {
    http_response_code(400);
    die;
 }

diff --git a/js/scripts.js.php b/js/scripts.js.php
@@ -1318,6 +1318,11 @@ function plugin_formcreator_changeDropdownItemtype(rand) {
       $('.plugin_formcreator_dropdown_ticket').toggle(showTicketCategorySpecific);
       $('.plugin_formcreator_dropdown_service_level').toggle();
 
+      if (!isNaN(dropdown_type)) {
+         // The variable seems not to be a itemtype
+         return;
+      }
+
       $.ajax({
          url: formcreatorRootDoc + '/ajax/commontree.php',
          type: 'GET',