fix(form): requesttype column no longer used

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

Author: btry

inc/form.class.php

@@ -1336,12 +1336,6 @@ public function prepareInputForAdd($input) {
          }
       }
 
-      if (!isset($input['requesttype'])) {
-         $requestType = new RequestType();
-         $requestType->getFromDBByCrit(['name' => ['LIKE', 'Formcreator']]);
-         $input['requesttype'] = $requestType->getID();
-      }
-
       return $input;
    }
 

install/mysql/plugin_formcreator_empty.sql

@@ -43,7 +43,6 @@ CREATE TABLE IF NOT EXISTS `glpi_plugin_formcreator_forms` (
   `icon_color` varchar(255) NOT NULL DEFAULT '',
   `background_color` varchar(255) NOT NULL DEFAULT '',
   `access_rights` tinyint(1) NOT NULL DEFAULT '1',
-  `requesttype` int(11) NOT NULL DEFAULT '0',
   `description` varchar(255) DEFAULT NULL,
   `content` longtext,
   `plugin_formcreator_categories_id` int(11) unsigned NOT NULL DEFAULT '0',

install/upgrade_to_2.11.php

@@ -144,6 +144,10 @@ public function upgrade(Migration $migration) {
          );
       }
       $migration->addField($table, 'sort_order', 'integer', ['after' => 'replace_helpdesk']);
+
+      // Remove unused column
+      $table = 'glpi_plugin_formcreator_forms';
+      $migration->dropField($table, 'requesttype');
    }
 
    /**

tests/suite-unit/PluginFormcreatorForm.php

@@ -454,7 +454,6 @@ public function testExport() {
          'icon_color',
          'background_color',
          'access_rights',
-         'requesttype',
          'description',
          'content',
          'is_active',