Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line wrap error with rich text #1139

Closed
pedroluisvsousa opened this issue Oct 14, 2018 · 16 comments
Closed

Line wrap error with rich text #1139

pedroluisvsousa opened this issue Oct 14, 2018 · 16 comments
Assignees
Labels
Milestone

Comments

@pedroluisvsousa
Copy link

pedroluisvsousa commented Oct 14, 2018

Line wrap error with rich text.

To Reproduce

  1. Enable the option:
    General > Assistance > Use rich text for helpdesk -> Yes
  2. Create a form with a textarea fild e destination for a change. At the destination of the form (change), the "List field" answer is assigned to the field impacts.
  3. Fill out the form with a list.

Expected behavior
In the impacts field the list is expected:

  1. one
  2. two
  3. three

Actual result
<p><p>1. one</p><p>2. two</p><p>3. three</p></p>

Screenshots
image
image
image

Desktop (please complete the following information):

  • OS: Mint Linux 19
  • Browser firefox 62.0.3,

I'm using 2.6.5-bugfix version.

btry added a commit to btry/formcreator that referenced this issue Oct 15, 2018

Unverified

No user is associated with the committer email.
fix pluginsGLPI#1139

Signed-off-by: btry <tbugier@teclib.com>
@btry btry mentioned this issue Oct 15, 2018
2 tasks
@btry btry self-assigned this Oct 15, 2018
@btry btry added the bug label Oct 15, 2018
@btry btry added this to the 2.6.5 milestone Oct 15, 2018
@btry
Copy link
Collaborator

btry commented Oct 15, 2018

Hi

Please test this fix and feedback.

image

@pedroluisvsousa
Copy link
Author

That's ok.

@btry
Copy link
Collaborator

btry commented Oct 17, 2018

Hi

Thank you for your feedback. The fix is ready for the next reelase.

@pedroluisvsousa
Copy link
Author

Hi,
Today I tested the current version 2.6.5 and an error similar to that reported in this issue occurred.
See the screenshots below.

screenshot_2018-11-01 glpi - forms - 2

screenshot_2018-11-01 glpi - form creator - 1

screenshot_2018-11-01 glpi - changes - 29

screenshot_2018-11-01 glpi - changes - 29 1

  • GLPI setup:

[code]   GLPI 9.3.1 (/glpi931 => /var/www/html/glpi931) Installation mode: TARBALL

Operating system: Linux localhost.localdomain 3.10.0-862.11.6.el7.x86_64 #1 SMP Tue Aug 14 21:49:04 UTC 2018 x86_64 PHP 7.2.11 apache2handler (Core, PDO, Phar, Reflection, SPL, SimpleXML, Zend OPcache, apache2handler, apcu, bz2, calendar, ctype, curl, date, dom, exif, fileinfo, filter, ftp, gd, gettext, hash, iconv, imap, intl, json, ldap, libxml, mbstring, mysqli, mysqlnd, openssl, pcre, pdo_mysql, pdo_sqlite, posix, session, shmop, sockets, sqlite3, standard, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, zlib) Setup: max_execution_time="30" memory_limit="128M" post_max_size="8M" safe_mode="" session.save_handler="files" upload_max_filesize="2M" Software: Apache/2.4.6 (CentOS) PHP/7.2.11 () Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0 Server Software: MySQL Community Server (GPL) Server Version: 5.7.23 Server SQL Mode: Parameters: glpiuser@localhost/glpi931 Host info: Localhost via UNIX socket mysqli extension is installed ctype extension is installed fileinfo extension is installed json extension is installed mbstring extension is installed zlib extension is installed curl extension is installed gd extension is installed simplexml extension is installed xml extension is installed ldap extension is installed imap extension is installed Zend OPcache extension is installed APCu extension is installed xmlrpc extension is installed CAS extension is installed Database version seems correct (5.7.23) - Perfect! /var/www/html/glpi931/files/_log : OK /var/www/html/glpi931/config : OK /var/www/html/glpi931/files : OK /var/www/html/glpi931/files/_dumps : OK /var/www/html/glpi931/files/_sessions : OK /var/www/html/glpi931/files/_cron : OK /var/www/html/glpi931/files/_graphs : OK /var/www/html/glpi931/files/_lock : OK /var/www/html/glpi931/files/_plugins : OK /var/www/html/glpi931/files/_tmp : OK /var/www/html/glpi931/files/_cache : OK /var/www/html/glpi931/files/_rss : OK /var/www/html/glpi931/files/_uploads : OK /var/www/html/glpi931/files/_pictures : OK Web access to the files directory should not be allowed Check the .htaccess file and the web server configuration. SELinux mode is Disabled

htmLawed version 1.2.4 in (/var/www/html/glpi931/lib/htmlawed) SimplePie version 1.5.2 in (/var/www/html/glpi931/vendor/simplepie/simplepie/library) TCPDF version 6.2.17 in (/var/www/html/glpi931/vendor/tecnickcom/tcpdf) michelf/php-markdown in (/var/www/html/glpi931/vendor/michelf/php-markdown/Michelf) true/punycode in (/var/www/html/glpi931/vendor/true/punycode/src) iacaml/autolink in (/var/www/html/glpi931/vendor/iamcal/lib_autolink) sabre/vobject in (/var/www/html/glpi931/vendor/sabre/vobject/lib) phpCas version 1.3.5 in (/usr/share/pear)

Not active

Way of sending emails: PHP

 

formcreator Name: Formulários Version: 2.6.5 State: Enabled
[/code]

@btry
Copy link
Collaborator

btry commented Nov 1, 2018

Hi

please try this fix and feedback quickly. Release is imminent.

https://github.com/pluginsGLPI/formcreator/pull/1178/files

@btry btry reopened this Nov 1, 2018
@btry btry mentioned this issue Nov 1, 2018
2 tasks
@pedroluisvsousa
Copy link
Author

Hi,
the problem with the characters was resolved.
screenshot_2018-11-02 glpi - changes - 30 1

However there is a formatting problem in the Description field.
screenshot_2018-11-02 glpi - changes - 30

@pedroluisvsousa
Copy link
Author

pedroluisvsousa commented Nov 2, 2018

When you set "Use rich text for helpdesk = NO", the problem persists.
screenshot_2018-11-02 glpi - changes - 4
screenshot_2018-11-02 glpi - changes - 4 1

@btry
Copy link
Collaborator

btry commented Nov 2, 2018

i reproduce with rich text mode. and added a fix.

In this comment #1139 (comment), you was with rich text disabled ?

@btry
Copy link
Collaborator

btry commented Nov 2, 2018

Ok, I reproduced also without rich text.

An other update to the fix is online.I'm waiting for your feedback. Few hours left before the release due to the week end.

@pedroluisvsousa
Copy link
Author

Correcting the previous post:
When you set "Use rich text for helpdesk =NO", the problem persists.
screenshot_2018-11-02 glpi - changes - 4
screenshot_2018-11-02 glpi - changes - 4 1

@btry
Copy link
Collaborator

btry commented Nov 2, 2018

Hi,

I figured it out. Please download the new changes and try again.

@pedroluisvsousa
Copy link
Author

Which branch should I test?

@btry
Copy link
Collaborator

btry commented Nov 2, 2018

The same, new commits were pushed into it

@btry
Copy link
Collaborator

btry commented Nov 2, 2018

@pedroluisvsousa
Copy link
Author

Hi,
It has been tested in both modes. That's OK. Thank you very much.

@btry
Copy link
Collaborator

btry commented Nov 2, 2018

great ! I merge, thank you for your feedback !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants