Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad label in the menu - version 2.9.0-beta 1 #1516

Closed
mab18 opened this issue Oct 4, 2019 · 13 comments
Closed

Bad label in the menu - version 2.9.0-beta 1 #1516

mab18 opened this issue Oct 4, 2019 · 13 comments
Assignees
Labels
Milestone

Comments

@mab18
Copy link

mab18 commented Oct 4, 2019

In stable version, label in the menu is (in FR ) "Formulaires", but in the 2.9.0 beta 1 this label is "Forms"

To Reproduce
Install in a FR installation the upgrade 2.9.0 B1

Expected behavior
The label in FR in the menu should be "Formulaires"

Screenshots
plugin Formcreator - bug - mauvaise traduction - version  2 9 0-beta 1 - 01
plugin Formcreator - bug - mauvaise traduction - version  2 9 0-beta 1 - 02

@btry
Copy link
Collaborator

btry commented Oct 4, 2019

Hi

I don't reproduce. Maybe there is a caching problem in translations (introduced in GLPI 9.4). Can you try to reset the cache then see if this solves the issue ?

@btry btry added this to the 2.9.0-beta.2 milestone Oct 7, 2019
@btry
Copy link
Collaborator

btry commented Oct 16, 2019

Hi

Did you try to reset the cache for translations of GLPI ?

@mab18
Copy link
Author

mab18 commented Oct 17, 2019

Hi,
I try immediatly, sry 4 delay

@mab18
Copy link
Author

mab18 commented Oct 17, 2019

It works with actual develop branch.
For me, it's corrected and without reset cache (maybe changes or reset since the time of creation of this issue).
Excellent, but what was the problem ? ;-)
Have a nice day, for me, it's ok with this release now.
Is there any difficults updates who should be tried In this Beta ?

@btry
Copy link
Collaborator

btry commented Oct 17, 2019

The develop branch is for versions 2.8.x. You reported the issue with versions 2.9 (currently support/2.9.0 branch). Then I expect that if you upgrade to 2.9.0-beta the bug will occur again.

I assume there were some changes in translations like a single localizable string converted to a single / plural one.

Is there any difficults updates who should be tried In this Beta ?

I don't understand your question. Do you want to know which parts of the plugin may contain bugs or regressions ?

@mab18
Copy link
Author

mab18 commented Oct 17, 2019

Ouch...
I was right to precise this... Please, from what branch does I need to download the version (release beta, support 2.9 ?)?
LOL, if you knew where was bugs or regressions, I think it should be easy to correct them ;-)
NO, I speaking about specific tests about developpements made in this version ;-) .

@btry
Copy link
Collaborator

btry commented Oct 17, 2019

the versions 2.9.x (including beta) are un support/2.9.0 for now. When the 1st production release will be ready, this branch will merge in develop.

Bugs or regressions come from undiscovered bugs in previous releases and some new bugs may happen in new features or refactored code. I did an effort to increase automated tests, but there are still lot of them to write. Moreover UI is not automatically tested. A PoC is done but requires time to cover the whole UI.

So I have idea of where may be the bugs, but they are no discovered yet :) Here is the power of the community : build real life cases, more complex than those I build.

@mab18
Copy link
Author

mab18 commented Oct 17, 2019

And already, you're doing a wonderful job.
I love free software because of that.
So, to test, does I need download from "release 2.9.0/beta.1" or "support/2.9.0" ? It's not clear for me and I am sorry about that.

@btry
Copy link
Collaborator

btry commented Oct 17, 2019

Ignore the branches release/xxxxx these exist only to build a release.

download the snapshot from support/2.9.0

  • you will need to download and install composer: https://getcomposer.org
  • run it from the folder of the plugin: composer install
  • then run vendor/bin/robo build:fa-data

Once done, the development version of the plugin is ready to test

@mab18
Copy link
Author

mab18 commented Oct 17, 2019

Merci to help me help you ;-)
I have bad news :
plugin formcreator - mauvaise traduction - 01
plugin formcreator - mauvaise traduction - 02
plugin formcreator - mauvaise traduction - 03
Reset does nothing.

btry added a commit to btry/formcreator that referenced this issue Oct 17, 2019
fix pluginsGLPI#1516

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
@btry
Copy link
Collaborator

btry commented Oct 17, 2019

Ok, I think I found the problem. The above commit fixes it for me. Can you validate it ?

@btry btry self-assigned this Oct 17, 2019
btry added a commit that referenced this issue Oct 17, 2019
fix #1516

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
@mab18
Copy link
Author

mab18 commented Oct 17, 2019

:-))
plugin formcreator - mauvaise traduction - 04 - corrigé
Excellent !
Comme j'aimerais savoir faire ça... je n'ai que de petites bases en PHP :-(

@btry
Copy link
Collaborator

btry commented Oct 17, 2019

Si vous connaissez bien le langage lui même, lancez vous ;). C'est dur au début, mais il n'y a pas de secret. C'est forgeant qu'on devient forgeron.

@btry btry closed this as completed Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants