Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PalettedBlockArray::fromData() does not require any user input about bits-per-block #29

Open
dktapps opened this issue Apr 27, 2022 · 0 comments
Labels
BC break Breaks API backwards compatibility enhancement New feature or request

Comments

@dktapps
Copy link
Member

dktapps commented Apr 27, 2022

Bits-per-block can be inferred from the size of the offset table (or $words), meaning that having this parameter at all is completely redundant.

The only thing bpb is required for is to know how many bytes to read when decoding palettes from disk, which is not something fromData has to care about. It only needs to care that the provided data is valid. This useless parameter is just providing an extra avenue for potential bugs.

@dktapps dktapps added enhancement New feature or request BC break Breaks API backwards compatibility labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks API backwards compatibility enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant