fix: use correct return type for View.Port #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
🎉 This PR is included in version 9.103.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The return type of
View.PortwasReactNodewhich is not correct as it's supposed to be used as a JSX element. The documented usage of the component/function was giving the following error:The main reason why
ReactNodecannot be used like this is becauseReactNodetype can possibly beundefinedwhich is not valid JSX (nullis the valid alternate). See more on stackoverflow: https://stackoverflow.com/questions/72392225/reactnode-is-not-a-valid-jsx-elementWhat
The return type of
View.Portis changed toJSX.Elementso it can be used as JSX. The TypeScript error is gone now.Checklist