fix: splitting things mixed in the useFont loader function logic #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Thanks! Appreciate the work which is maybe less shiny, but keeps stuff working. |
|
🎉 This PR is included in version 9.105.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 5, 2024
This was referenced Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Hello, we separated concerns inside the useFont loader function logic and refactored it to improve readability.
What
Separated concerns within the loader function for improved clarity and maintainability. Specifically, divided the font loading logic into two distinct functions:
loadFontDatafor fetching the font data asynchronously, andparseFontDatafor parsing the loaded font data.Checklist