-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Stats and StatsGl don't remove previous class names on rerender #1994
Merged
CodyJasonBennett
merged 2 commits into
pmndrs:master
from
lukehorvat:StatsGl-classNames-cleanup
Jun 15, 2024
Merged
fix: Stats and StatsGl don't remove previous class names on rerender #1994
CodyJasonBennett
merged 2 commits into
pmndrs:master
from
lukehorvat:StatsGl-classNames-cleanup
Jun 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
🎉 This PR is included in version 9.107.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Both
Stats
andStatsGl
don't remove class names set via theclassName
prop on rerender. In the following example, ifshowStats
is initiallyfalse
and then later changes totrue
, theHidden
class does not get removed from the DOM element.What
Fixed by removing the previously added class names during
useEffect
cleanup.Checklist