-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(GizmoHelper): allow GizmoHelper to be used with camera-controls #2066
Merged
CodyJasonBennett
merged 1 commit into
pmndrs:master
from
a3ng7n:fix/1399-gizmo-with-camera-controls
Aug 19, 2024
Merged
fix(GizmoHelper): allow GizmoHelper to be used with camera-controls #2066
CodyJasonBennett
merged 1 commit into
pmndrs:master
from
a3ng7n:fix/1399-gizmo-with-camera-controls
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using camera-controls sets target via the getTarget method, and updates the control position via the setPosition method
@a3ng7n is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Thanks. |
🎉 This PR is included in version 9.111.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 17, 2024
This was referenced Sep 19, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using camera-controls sets target via the getTarget method, and updates the control position via the setPosition method.
Why
Allows GizmoHelper to be used alongside CameraControls/camera-controls.
resolves #1399
What
Fixes two issues:
CameraControls
doesn't expose atarget
property directly - so whenfocusPoint
is set at animation start, get the target viaCameraControls
getTarget
instead.CameraControls
doesn't seem to like having its camera moved directly, and will continuously attempt to reset themainCamera
's position - the fix is to callCameraControls
setPosition
method after themainCamera
's position is updated, and before it has a chance to revert it.Checklist
I did create a storybook entry that's just a duplicate of the GizmoHelper story below but using CameraControls to test the fix out - but I didn't think it was really value added / worthy of another tutorial entry
drei/.storybook/stories/GizmoHelper.stories.tsx
Lines 51 to 86 in f4f910f