Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GradientTexture type overlapping with Texture type #2099

Merged

Conversation

Nickardson
Copy link
Contributor

Why

Closes issue #1962, where the type property of Texture was conflicting with the type property of GradientTexture.

What

Use Omit to remove Texture's type property from the interface and removed a now-unnecessary @ts-ignore.

Checklist

  • Ready to be merged

Copy link

vercel bot commented Sep 19, 2024

@Nickardson is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@CodyJasonBennett CodyJasonBennett merged commit 1dfd9a0 into pmndrs:master Sep 22, 2024
3 of 4 checks passed
Copy link

🎉 This PR is included in version 9.113.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants