SpriteAnimator/useSpriteLoader types
#2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abernier
reviewed
Nov 11, 2024
abernier
reviewed
Nov 11, 2024
abernier
reviewed
Nov 12, 2024
|
imo, SpriteAnimator could also be simplified a lot |
I'll check it out and run some tests, I think one of the latest changes on useSpriteLoader is causing re-renders |
|
@netgfx are we good to merge? |
I'll perform some tests and let you know as soon as possible |
|
@abernier I think we are good to go |
|
🎉 This PR is included in version 9.116.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Better typescript support for inner variables and functions for SpriteAnimator
What
Added more robust and detailed types for SpriteAnimator
Checklist