Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shaderMaterial uniforms are shared between instances #283

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

emmelleppi
Copy link
Member

What

adds the clone of uniforms, preventing the use of the same instance
Resolves #190

@vercel
Copy link

vercel bot commented Feb 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/mgos49b06
✅ Preview: https://drei-git-shadermaterial-multiple-instances-fix.pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ae58bb3:

Sandbox Source
green-paper-skzxl Configuration
drei reflector Configuration
objective-kare-9jp0u Issue #190

@joshuaellis
Copy link
Member

Thanks, @emmelleppi!

LGTM, @drcmda be good to get your 👍🏼 before merge.

@emmelleppi
Copy link
Member Author

Here a cbs with the deploy

https://codesandbox.io/s/nice-wood-o89f1?file=/src/index.js

@joshuaellis joshuaellis changed the base branch from master to beta February 3, 2021 18:18
@joshuaellis joshuaellis merged commit 7a4e72a into beta Feb 3, 2021
@joshuaellis joshuaellis deleted the shadermaterial-multiple-instances-fix branch February 3, 2021 18:18
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 3.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released on @beta released in beta for review label Feb 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta released in beta for review released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shaderMaterial uniforms are shared between instances
3 participants