Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build in Angular with errors in types/postprocessing.d.ts #395

Closed
Zundrium opened this issue Aug 3, 2022 · 7 comments
Closed

Can't build in Angular with errors in types/postprocessing.d.ts #395

Zundrium opened this issue Aug 3, 2022 · 7 comments
Labels
support User support and general help

Comments

@Zundrium
Copy link

Zundrium commented Aug 3, 2022

I'm having issues with building after including the EffectComposer.

I assume I'm doing something wrong because I haven't found any results about this. But I have no idea where to look, the error is as follows:

In an empty Angular project I install three, @types/three and postprocessing.

import {EffectComposer} from 'postprocessing' triggers the following errors:

'fullscreenMaterial' is defined as an accessor in class 'Pass', but is overridden here in 'AdaptiveL
uminancePass' as an instance property.
'fullscreenMaterial' is defined as an accessor in class 'Pass', but is overridden here in 'CopyPass'
 as an instance property.
'fullscreenMaterial' is defined as an accessor in class 'Pass', but is overridden here in 'DepthCopy
Pass' as an instance property.
... and many more 

Does someone know where I have to look?

@Zundrium Zundrium changed the title Can't build with errors in types/postprocessing.d.ts Can't build in Angular with errors in types/postprocessing.d.ts Aug 4, 2022
@Zundrium
Copy link
Author

Zundrium commented Aug 4, 2022

Reverting back to version 6.25.0 (last one without type files) and declaring postprocessing as a module allows me to compile the project. Not really a solution though.

@vanruesc
Copy link
Member

vanruesc commented Aug 4, 2022

There has to be something wrong with your setup. Any chance you could provide a repository with a minimal reproduction of the issue?

@vanruesc vanruesc added the support User support and general help label Aug 4, 2022
@Zundrium
Copy link
Author

Zundrium commented Aug 7, 2022

Thanks for your reply @vanruesc , it happens in an empty Angular project with the steps I mentioned above.

@Cloov
Copy link

Cloov commented Aug 8, 2022

I've had the same issue, but not while using Angular. I'm using threejs 0.143.0, which is currently the latest release, and I'm also using @types/three ^0.143.0.

My full dependencies are as follows:

	"devDependencies": {
		"@types/three": "^0.136.1",
		"autoprefixer": "^10.4.0",
		"prettier": "^2.5.0",
		"sass": "^1.43.5",
		"typescript": "^4.3.2",
		"vite": "^2.6.14"
	},
	"dependencies": {
		"path": "^0.12.7",
		"three": "^0.136.0",
		"lil-gui": "^0.16.0",
		"vite-plugin-live-reload": "^2.1.0"
	}

@vanruesc
Copy link
Member

The types have been updated and validated in postprocessing@6.28.7. Please check again if the reported issue still persists.

@Cloov
Copy link

Cloov commented Sep 1, 2022

Good news: no more errors for me, personally, upon updating to postprocessing@6.28.7. Thanks for the update!

@vanruesc
Copy link
Member

Closing this as it seems to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support User support and general help
Projects
None yet
Development

No branches or pull requests

3 participants