Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

three.js incompatibilities in r162 due to code deprecated in r152 #603

Closed
hybridherbst opened this issue Feb 21, 2024 · 2 comments
Closed
Labels
discussion An open discussion or announcement

Comments

@hybridherbst
Copy link

hybridherbst commented Feb 21, 2024

Description of the bug

three.js r162 will remove the legacy LinearEncoding and sRGBEncoding fields (they're already gone on dev). See mrdoob/three.js#27656

This currently breaks the v6 postprocessing package. I think while v7 is in alpha it would be good to still support recent three.js versions if possible.

They have now been deprecated since r152 (https://discourse.threejs.org/t/updates-to-color-management-in-three-js-r152/50791), so I think it's been enough time to update here too. What do you think?

To Reproduce

Use v6 version of the package with three dev branch (after the merge of this PR).

Screenshots

image

Library versions used

  • Three: [r162dev]
  • Post Processing: [6.34.3]
@vanruesc
Copy link
Member

Thanks for the heads-up!

I think it's been enough time to update here to. What do you think?

Yeah, we'll have to raise the minimum version of three to r152 and remove the old code.

I think while v7 is in alpha it would be good to still support recent three.js versions if possible.

v6 will be updated regularly at least until v7 is production-ready. For v7, I'm thinking about supporting the six most recent releases of three. Older versions may still work, but won't be officially supported. The first release of v7 will also most likely require the most recent version of three at that time, expanding forward until the range includes six releases.

Technically speaking, every peer dependency version update would be a breaking change that necessitates a major version bump, but almost every three release contains some kind of breaking change, so I'm not sure if we should follow semver that closely in that regard.

@vanruesc vanruesc added the discussion An open discussion or announcement label Feb 22, 2024
@hybridherbst
Copy link
Author

I know, three versioning is fun...

[for 6.x] raise the minimum version of three to r152 and remove the old code
[for 7.x] will also most likely require the most recent version of three at that time

Both sound good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion An open discussion or announcement
Projects
None yet
Development

No branches or pull requests

2 participants