Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width issue #42

Closed
pquerner opened this issue Jul 17, 2023 · 10 comments
Closed

Width issue #42

pquerner opened this issue Jul 17, 2023 · 10 comments
Assignees
Labels

Comments

@pquerner
Copy link

pquerner commented Jul 17, 2023

Hello!

I am building a rework of my blog with your theme. Everything is great so far, but I have one issue.

On my macbookpro I have a article which is behaving like this:

image

while all other posts look like

image image image

I have no idea how to debug this, but I am sure its the content width (since its the biggest post, with loads of codeblocks, long sentences etc.).

Maybe its because my "featured" posts doesnt have images?

This was on 1.0.5, I tested 1.0.6 with demo data (had the demo data on 1.0.5 too) and it doesnt happend there.

I am an absolute noob in anything css/template related.
Can you could help me?, your next beer is on me for sure! :)

@pquerner
Copy link
Author

pquerner commented Jul 18, 2023

I've ported my post into the demo page, post five, and can confirm it also happens there.
So something about my formatting. :(

https://gist.github.com/pquerner/3d9631ccdb7136b928e5f7733b842d17

@pmoreno-rodriguez
Copy link
Owner

Hi @pquerner, have you any test website online where I can see your issue?

@pquerner
Copy link
Author

Sadly, no. But I added the gist with my blog post files, see here:
https://gist.github.com/pquerner/3d9631ccdb7136b928e5f7733b842d17

I've imported this into a new instance of grav using your theme (latest version 1.0.6) and its still there.

Maybe its the (long width) codeblocks or something.

@pquerner
Copy link
Author

I've uploaded a dev instance with the new stuff here: https://blogdev.querner.dev/

auth: blogdev / blognewfuture2021
(nothing worth protecting, its all public anyway, but I dont want duplicate content)

@pmoreno-rodriguez
Copy link
Owner

Hi @pquerner.

Try with this css. You have to overwrite the old files in assets/css folder.
css.zip

Please, tell me if this changes work fine.

@pmoreno-rodriguez
Copy link
Owner

Which version of theme are you using?. I have seen you don't have the crossmark to close sidebar menu.

@pquerner
Copy link
Author

1.0.5 runs on the internet, locally I switched to 1.0.6 now - same thing in regards to the css issue. I am in the process now of upgrading my overwritten templates so I get the latest changes. (Only removed small stuff, like I dont use images, or I want my links to check if the page is active and whatnot)

I can confirm the css fixes it "partially".
I have uploaded those two files onto the dev server aswell.

What I witnessed is, that the padding is slightly bigger on the blog-listing page than on a blog-item page. Probably not a big deal. (But it doesnt happen on pages without code blocks, so worth meantioning)

image image

May I ask what was the issue?

@pmoreno-rodriguez
Copy link
Owner

I increased the width of both the sidebar and the main so that they would occupy the 100% width, putting the sidebar in percentage (maximum of 25%) and the rest for the main.

It should work, since before it was as width in pixels.

I have seen that you load your own css from other plugins, maybe you should make some adjustments in the misc.css file, intended for that purpose.

@pquerner
Copy link
Author

Nice!

Can confirm that this is all that it took:

#wrapper {
    width: 100%;
}

#main {
    width: inherit;
    min-width: 70%;
}

#sidebar {
    min-width: 20%;
    width: 25%;
}

(from your .css files)

@pquerner
Copy link
Author

Oh I forgot. Please add a donation button to the readme so I can buy you a coffee/beer. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants