Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

was giveOutStaticFile checked for security vs downloading arbitrary files? #12

Open
nruth opened this issue Oct 12, 2014 · 1 comment
Open

was giveOutStaticFile checked for security vs downloading arbitrary files? #12

nruth opened this issue Oct 12, 2014 · 1 comment

Comments

@nruth
Copy link

nruth commented Oct 12, 2014

in the rails api entry for send_file:

Be careful to sanitize the path parameter if it is coming from a web page. send_file(params[:path]) allows a malicious user to download any file on your server.
@olivervbk
Copy link

No, it is not. After checking it out I came across the problem:
Issue: #26 (I've fixed it in a PR: #25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nruth @olivervbk