-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psl examples #52
Labels
Comments
drgona
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Aug 25, 2023
All
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aarontuor @aaron-tuor @madelynshapiro
The current toml file does not include all the dependencies necessary to run psl examples in:
https://github.com/pnnl/neuromancer/tree/master/examples/psl
there are broken notebook examples:
all psl examples lack proper documentation to guide the user through the functionality of the library
There are also broken psl examples in the test folder:
https://github.com/pnnl/neuromancer/blob/master/tests/psl/coupled_sys_test.ipynb
Missing dependencies:
Failing tests in: psl\test_directory.py
assert os.path.normcase(nm_path1)==os.path.normcase(nm_path2), 'installed neuromancer root directory not the same as test root directory' AssertionError: installed neuromancer root directory not the same as test root directory
I am of strong opinion not to include all these psl_gym dependencies in our base environment.
the pygame visualisation should be a separate project independent of Neuromancer for now
The text was updated successfully, but these errors were encountered: