Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Common Coin use in Agreement. #37

Closed
afck opened this issue May 22, 2018 · 4 comments
Closed

Fix Common Coin use in Agreement. #37

afck opened this issue May 22, 2018 · 4 comments
Labels

Comments

@afck
Copy link
Collaborator

afck commented May 22, 2018

The algorithm needs a third round of messages (Conf), otherwise an adversary that controls the network scheduler and one node can potentially stall agreement: amiller/HoneyBadgerBFT#59

@vkomenda
Copy link
Contributor

As suggested in the link to the description of the bug above, we use the approach of the paper "Cobalt: BFT Governance in Open Networks", https://arxiv.org/abs/1802.07240 , section 4.3.2. This is yet another important paper in the context of hbbft since it touches upon the greater problem of decentralized governance, and uses a modular protocol related to Honey Badger where the Agreement issue has been fixed.

@vkomenda
Copy link
Contributor

It'd be great to come up with adversarial tests attacking the optimistic common coin schedule of #69. So that we test the difference from the paper version of Honey Badger.

@afck
Copy link
Collaborator Author

afck commented Jul 30, 2018

Apart from the tests, this is done. But the Conf messages might allow further optimizations.

@afck
Copy link
Collaborator Author

afck commented Oct 9, 2018

Closing this, since we have #228 for the missing test.

@afck afck closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants