Skip to content
This repository has been archived by the owner on Jun 29, 2020. It is now read-only.

Event log is beneficial to the observation of setting variables #125

Closed
pablofullana opened this issue May 14, 2018 · 3 comments
Closed
Assignees
Labels

Comments

@pablofullana
Copy link

Observation: When calling setSigner() with a new signer address, it is highly recommended that you emit an event to log the execution. This is not standard behavior, though it helps you track the history and lets you notice the variable has been changed. Similar functions are listed below: setRegistry(), registerAddress(), unregisterAddress()

@phahulin
Copy link
Contributor

Let's also add an event for confirmAddress(). @pablofullana what do you think? Then we'll have a complete lifecycle reflected in events

@pablofullana
Copy link
Author

Indeed, sounds logical to have that one as well. @fvictorio any thoughts against this?

@fvictorio
Copy link
Contributor

No, that makes sense 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants