Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 6.0 #67

Closed
lifeiscontent opened this issue Aug 19, 2020 · 6 comments
Closed

Storybook 6.0 #67

lifeiscontent opened this issue Aug 19, 2020 · 6 comments
Labels
category: question Further information is requested

Comments

@lifeiscontent
Copy link
Member

Hey @pocka does this addon work with 6.0 yet?

@schonarth
Copy link

I just waited to install the addon after upgrading Storybook, and now it won't work. I'm not sure if I'm doing something wrong or if it isn't compatible.

@pocka pocka added the category: question Further information is requested label Aug 20, 2020
@pocka
Copy link
Collaborator

pocka commented Aug 20, 2020

Yes, as described in README, this addon works with Storybook v5.0.0 and later.

If you encounter a bug, please file an issue with versions of Storybook and the addon you're using.
Since there are no issue templates yet, these would be helpful:

  • Versions
    • @storybook/<framework>
    • storybook-addon-designs
    • Other addons if needed
  • Reproduction repository (CodeSandbox is okay too) or Configuration
  • Is there an error OR the addon does not appear without any errors?

@pocka pocka closed this as completed Aug 20, 2020
@schonarth
Copy link

I got it. Had to change the myStory.story = { parameters: { ... for the Basic.parameters = { ... syntax. Then it worked.

Thanks!

@pocka
Copy link
Collaborator

pocka commented Aug 20, 2020

Ah, I missed that! I'll update README and docs later.

@JoshRobertson
Copy link

@pocka can there be an update to the peer dependencies to support storybook ^5.0.0 || ^6.0.0 to remove the warnings when installing with Storybook 6?

warning " > storybook-addon-designs@5.4.1" has incorrect peer dependency "@storybook/addons@^5.0.0".
warning " > storybook-addon-designs@5.4.1" has incorrect peer dependency "@storybook/components@^5.0.0".
warning " > storybook-addon-designs@5.4.1" has incorrect peer dependency "@storybook/theming@^5.0.0".

@pocka
Copy link
Collaborator

pocka commented Sep 16, 2020

@JoshRobertson Thank you for pointing out!

I've just published v5.4.2 that uses ^5.0.0 || ^6.0.0 query for the Storybook modules in peerDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants