Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "loading..." when asset has been loaded #81

Closed
iwan-uschka opened this issue Feb 17, 2021 · 4 comments · Fixed by #82
Closed

Remove "loading..." when asset has been loaded #81

iwan-uschka opened this issue Feb 17, 2021 · 4 comments · Fixed by #82
Assignees
Labels
category: bug Something isn't working

Comments

@iwan-uschka
Copy link

I am using type: "iframe" to load image assets. Reason: type: "image" disables scrolling which doesn't make sense in my case. When using type: "iframe" a loading label is placed behind the iframe itself. If the content of the iframe doesn't fit the full width or height you can see the loading label which can be confusing.

An alternative could be to add an option to type: "image" to enable scrolling and disable offset :)

@pocka pocka added category: bug Something isn't working category: feature New feature or request and removed category: feature New feature or request labels Feb 17, 2021
@pocka
Copy link
Collaborator

pocka commented Feb 17, 2021

The remaining loading... label is due to my laziness... 🤦 It's visible when the site has no background color. I remember I noticed it at some time but it went off my mind then. It should be hide when the iframe content is loaded.

type: "image" disables scrolling which doesn't make sense in my case.

I don't think the addon prevents scrolling. The addon panel is not scrollable by default. For type: "image" preview, you can pan around by click-and-drag.

@iwan-uschka
Copy link
Author

For type: "image" preview, you can pan around by click-and-drag

True. Not yet noticed :)

Thanks for your response and for looking into it!

@pocka pocka self-assigned this Feb 18, 2021
pocka added a commit that referenced this issue Feb 18, 2021
#81

When embedding pages with no backgrounds, the "loading..." placeholder
label would be visible. This commit hides it when the iframe is loaded.
@pocka
Copy link
Collaborator

pocka commented Feb 18, 2021

Fixed in v5.4.4.

@pocka pocka closed this as completed Feb 18, 2021
@iwan-uschka
Copy link
Author

Thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants