Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paramKey to be able to disable #57

Merged
merged 6 commits into from
Jun 7, 2020

Conversation

matheo
Copy link
Member

@matheo matheo commented May 30, 2020

Added paramKey to the addon, exported interfaces, added example story with Design disabled, and added story-source to have self-explanatory stories in the documentation.

Copy link
Collaborator

@pocka pocka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vercel (former Zeit Now) stopped building preview due to "changes to now.json", which is not true for this PR, is kind weird... I authorized the changes so you can see the preview.

The previous comment is for config/stories modification (I left individual comments here). I appreciate the story-source addition!

packages/examples/.storybook/main.js Outdated Show resolved Hide resolved
Comment on lines +20 to +23
"@storybook/addons": "^5.3.19",
"@storybook/components": "^5.3.19",
"@storybook/core-events": "^5.3.19",
"@storybook/theming": "^5.3.19",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@storybook/addons": "^5.3.19",
"@storybook/components": "^5.3.19",
"@storybook/core-events": "^5.3.19",
"@storybook/theming": "^5.3.19",
"@storybook/addons": "^5.0.3",
"@storybook/components": "^5.0.3",
"@storybook/core-events": "^5.0.3",
"@storybook/theming": "^5.0.3",

These changes don't affect the users nor dev installation because of ^: upgrading lock file is the only thing required to upgrade dev dependencies (except major version changes).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, it's just good to keep track of the latest storybook when the library is released.

packages/examples/stories/tests/placeholder.stories.jsx Outdated Show resolved Hide resolved
packages/examples/.storybook/manager.js Outdated Show resolved Hide resolved
packages/examples/.storybook/manager.js Outdated Show resolved Hide resolved
packages/examples/.storybook/preview.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@pocka pocka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matheo
Copy link
Member Author

matheo commented Jun 6, 2020

@pocka no new beta release with this?

@pocka
Copy link
Collaborator

pocka commented Jun 7, 2020

Sorry, just forgot to merge 😱

@pocka pocka merged commit 15f028b into storybookjs:v5.3.0 Jun 7, 2020
@pocka
Copy link
Collaborator

pocka commented Jun 7, 2020

Available from v5.3.0-beta.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants