-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paramKey to be able to disable #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vercel (former Zeit Now) stopped building preview due to "changes to now.json", which is not true for this PR, is kind weird... I authorized the changes so you can see the preview.
The previous comment is for config/stories modification (I left individual comments here). I appreciate the story-source addition!
"@storybook/addons": "^5.3.19", | ||
"@storybook/components": "^5.3.19", | ||
"@storybook/core-events": "^5.3.19", | ||
"@storybook/theming": "^5.3.19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"@storybook/addons": "^5.3.19", | |
"@storybook/components": "^5.3.19", | |
"@storybook/core-events": "^5.3.19", | |
"@storybook/theming": "^5.3.19", | |
"@storybook/addons": "^5.0.3", | |
"@storybook/components": "^5.0.3", | |
"@storybook/core-events": "^5.0.3", | |
"@storybook/theming": "^5.0.3", |
These changes don't affect the users nor dev installation because of ^
: upgrading lock file is the only thing required to upgrade dev dependencies (except major version changes).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, it's just good to keep track of the latest storybook when the library is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@pocka no new beta release with this? |
Sorry, just forgot to merge 😱 |
Available from v5.3.0-beta.1 |
Added
paramKey
to the addon, exported interfaces, added example story with Design disabled, and added story-source to have self-explanatory stories in the documentation.