Simplify wrapper with storybook hooks API #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocka
reviewed
May 2, 2021
There was a problem hiding this comment.
@shilman
Thank you for the PR!
One question: which version of Storybook the hooks API is first implemented?
I'm asking because this addon currently supports Storybook@>=5.0.0 so I need to bump it (README and package.json maybe) before shipping this PR.
|
I think the hooks were introduced in 5.1, but didn't stabilize until 5.2 or 5.3. We want people to upgrade to 6.0+, so bumping the addon's support to 6.0+ would certainly help that 😉 |
|
The problem has been there so long and some (many?) users reported bugs related to it. Less side-effect = More happiness. Huge thanks! |
pocka
added a commit
that referenced
this pull request
May 7, 2021
*Related:* <#97 (comment)> Storybook team recommends to users to upgrade to v6. v5 has different CSF syntax and supporting broad range of versions is hard for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
I saw a problem where the design wasn't loading on the initial story until I switched stories and switched back. When I looked at the addon source I found that it's reimplementing a bunch of state management that's already handled by Storybook's hook API. So I updated the code accordingly.
How to test
I ran the example in the monorepo to check the different examples, but I'm not sure I tested all cases. If you can test it or suggest the best way for me to test it, I'd be happy to follow up.