Fix an encoding error with non-standard chars #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm being affected by this too, and this solution looks right to me. Thanks @alokhmutov ! My guess is that ruby 3.2 started raising a Is there any chance of getting this two-month-old PR reviewed/merged/released? |
|
(Actually, looking at the ruby bug the original rescue links to... I'm very confused whats' going on, and am not completely sure of the fix now! But something is going on that needs to be fixed...) |
|
Hi alokhmutov and jrochkind, thank you for opening the issue and this PR. This was fixed in #111 and will be available in the version 1.1.1 of device detector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105