Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RuboCop? #74

Closed
utkarsh2102 opened this issue Jun 19, 2020 · 2 comments
Closed

Use RuboCop? #74

utkarsh2102 opened this issue Jun 19, 2020 · 2 comments

Comments

@utkarsh2102
Copy link

Hi @spiderpug,

Thanks for maintaining this so far!
However, there are a bunch of things that could be fixed according to the Ruby style guide.

Would you consider using RuboCop?
I would be happy to raise a PR if so :)
@spiderpug
Copy link
Contributor

Thank you for your suggestion.

We use Rubocop internally as well so I added some rules and adjusted the models in fad9de5 .

@utkarsh2102
Copy link
Author

Hi @spiderpug,

Thanks! Could you also update RuboCop to v0.89? I can make a PR too, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spiderpug @utkarsh2102