fix: include layout_name in podium_layout_version_info #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
## [5.2.15](v5.2.14...v5.2.15) (2024-11-13) ### Bug Fixes * include layout_name in podium_layout_version_info ([#512](#512)) ([9b9c531](9b9c531))
|
🎉 This PR is included in version 5.2.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit torn whether this should be a separate metric or not. The layout doesn't have much additional stuff, but see podium-lib/podlet#432 for example.
We should stay consistent, so I guess my question is "do we stuff everything in
podium_layout_version_infoandpodium_podlet_version_infoor not?"