Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use ES private properties instead of Symbols and defineProperty… #84

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

trygve-lie
Copy link
Contributor

…() for privacy

BREAKING CHANGE: Due to dropping node 10.x support we use ES private properties instead of Symbols and .defineProperty().

…() for privacy

BREAKING CHANGE: Due to dropping node 10.x support we use ES private properties instead of Symbols and `.defineProperty()`.
Copy link

@alexanbj alexanbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trygve-lie trygve-lie merged commit 37fd140 into next Jul 29, 2020
@trygve-lie trygve-lie deleted the privacy branch July 29, 2020 13:38
github-actions bot pushed a commit that referenced this pull request Jul 29, 2020
# [5.0.0-next.4](v5.0.0-next.3...v5.0.0-next.4) (2020-07-29)

### Features

* Use ES private properties instead of Symbols and defineProperty() for privacy ([#84](#84)) ([37fd140](37fd140))

### BREAKING CHANGES

* Due to dropping node 10.x support we use ES private properties instead of Symbols and `.defineProperty()`.

Co-authored-by: Trygve Lie <trygve.lie@finn.no>
@github-actions
Copy link

🎉 This PR is included in version 5.0.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Nov 28, 2023
# [5.0.0](v4.2.86...v5.0.0) (2023-11-28)

### Bug Fixes

* Update @podium/utils to version 5.0.0-next.1 ([29da2c9](29da2c9))
* Use v5 versions of @podium/utils and @podium/schema ([a37ca1f](a37ca1f))

### Features

* Convert to ESM ([#150](#150)) ([9f3c2d3](9f3c2d3))
* Drop node 10.x support ([bcd95a1](bcd95a1))
* Support manifest with array of proxy endpoints ([#226](#226)) ([330384b](330384b))
* Use ES private properties instead of Symbols and defineProperty() for privacy ([#84](#84)) ([37fd140](37fd140))

### BREAKING CHANGES

* Convert from CommonJS to ESM

* feat: Convert to ESM

Co-authored-by: Trygve Lie <trygve.lie@finn.no>
* Due to dropping node 10.x support we use ES private properties instead of Symbols and `.defineProperty()`.

Co-authored-by: Trygve Lie <trygve.lie@finn.no>
* Only support node 12 and 14.
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants