pods_clean_name cleanup

[PodsBot]

pods_clean_name usage and definition needs some tweaking.

pods/includes/data.php

Line 1310 in 2446a2d

function pods_clean_name ( $orig, $lower = true, $trim_underscores = true ) {

• Update pods_clean_name function with code in comment
• Add new pods_js_name function
• All DOM usage of pods_clean_name should now use pods_js_name (see: https://github.com/pods-framework/pods/search?q=pods_clean_name&utf8=%E2%9C%93)
• Class usage of pods_clean_name should use pods_js_name( $orig, false ) (see:

  pods/classes/PodsComponents.php

  Line 410 in ad02de6

  $component_data[ 'Class' ] = 'Pods_' . pods_clean_name( basename( $component, '.php' ), false );

  )
• Update [\w] matches in traversal code with [\w\-] in https://github.com/pods-framework/pods/blob/master/classes/PodsData.php#L1201 and https://github.com/pods-framework/pods/blob/master/classes/PodsData.php#L2278

[sc0ttkclark]

/**
 * Return a lowercase alphanumeric name (with underscores and dashes)
 *
 * @param string $orig Input string to clean
 * @param boolean $lower Force lowercase
 * @param boolean $trim_underscores Whether to trim off underscores
 *
 * @return string Sanitized name
 *
 * @since 1.2.0
 */
function pods_clean_name ( $orig, $lower = true, $trim_underscores = false ) {

    $str = trim( $str );
    $str = preg_replace( "/([^0-9a-zA-Z\-_])/", "", $str );
    $str = preg_replace( "/(_){2,}/", "_", $str );
    $str = preg_replace( "/(-){2,}/", "-", $str );

    if ( $lower ) {
        $str = strtolower( $str );
    }

    if ( $trim_underscores ) {
        $str = trim( $str, '_' );
    }

    return $str;

}

/**
 * Return a lowercase alphanumeric name (with underscores) for safe Javascript variable names
 *
 * @param string $orig Input string to clean
 * @param boolean $lower Force lowercase
 *
 * @return string Sanitized name
 *
 * @since 2.5.4
 */
function pods_js_name( $orig, $lower = true ) {

    $str = pods_clean_name( $orig, $lower );
    $str = str_replace( '-', '_', $str );

    return $str;

}

[sc0ttkclark]

Assigned to @quasel for PR on 2.x and release/3.0

[sc0ttkclark]

Added another task for traversal support

[quasel]

guess
$str = trim( $str ); should be
$str = trim( $orig );

[sc0ttkclark]

Yep, sorry about that, coding via a GitHub comment lol

[sc0ttkclark]

Can you also make this change to https://github.com/pods-framework/pods/blob/master/ui/fields/_db.php

var newval = $( this ).val().toLowerCase().replace( /([- ])/g, '_' ).replace( /([^0-9a-z_])/g, '' ).replace( /(_){2,}/g, '_' ).replace( /_$/, '' );

with:

var newval = $( this ).val().toLowerCase().replace( /(\s)/g, '_' ).replace( /([^0-9a-z_\-])/g, '' ).replace( /(_){2,}/g, '_' ).replace( /_$/, '' );