New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RustlsConfig to be reloadable #893

Open

tisonkun opened this issue Oct 7, 2024 · 1 comment

Labels

Contributor

tisonkun commented Oct 7, 2024

Currently, the RustlsConfig can be configured with a fallback RustlsCertificate whose key and cert are preloaded bytes.

In reality, key and cert files can be updated periodically. Requiring a restart to reload the tls configs can be too expensive.

In GreptimeDB, there is a tech to reload files and the bytes will be read every time a new connection is established:

https://github.com/GreptimeTeam/greptimedb/blob/a283e13da744b6bbe3b08e7b0940ac2d3e03e4c6/src/servers/src/tls.rs#L169-L175

tisonkun added the enhancement label

Contributor Author

tisonkun commented Oct 14, 2024

cc @sunli829 WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment