New features for IRC Bot

[matejvelikonja]

I've added couple of changes to the existing code. All changes are written in README.md file. Would you like to merge this to projects together?

[super3]

Nice to see new features. Looking over it everything looks good. Just need to clean up the README a bit, but I can do that. I'll let pogosheep take a look then pull.

[DanielSiepmann]

Thanks for the nice work.
It'll take a bit time to test everything, clean up and documentation.

But you motivate us to work on the project again.
I'll try to finish this as fast as possible.

[matejvelikonja]

Great,
if you have any questions or need any help, don't hesitate to ask me.

[super3]

Lets just fix this up as we go. README is the first thing that needs fixing.

[super3]

@matejvelikonja Can you explain your 'listeners'? Also need to make the install, config, and run section a little more explanatory.

[matejvelikonja]

Listeners are similar to commands, but with one mayor difference. Commands are issued by users, while listeners listen to channel events, like JOIN, PRIVMSG, ...
Each listener registers to one or more keywords that listens to. When bot detects the keyword, it triggers the appropriate listener or even more listeners.

For now only one listener exists. The JoinListener, which listens for JOIN event and when this event occurs, the user is greeted with a message. For now the message is hardcoded in class, but it should be put into config file to make it configurable.

[super3]

Thanks. That all makes sense. What other listeners can we implement? The in the documentation it looks a little empty with only one listener implemented.

[matejvelikonja]

Just a couple of ideas from top of my head:
Swear word listener - listening if any of users is swearing and warn/ban/kick him
exit listener - logging when the user exists and when he returns greet him with message like, you haven't been here for x time
Logging could be implemented this way too. So all the chat would be archived and maybe available as HTML.

[super3]

Yeah I think they swear word listener would be a good place to start. We haven't implemented OP yet, so kick/ban would need that. We could though easily add a warning listener, and that could give us on more listener.

Should logging really be implemented as a listener? Makes logical sense that it would fall under a listener, but then again that listener its going to have much more code to actually log, and do we really want to stuff that into a listener file?

[matejvelikonja]

The swear word listener would be the simplest thing to do. Maybe we should just open an improvment issue on github and someone who will have time could do it.

About logging, I agree with you. It would be better to implement it on lower (bot) level. So that it logs everything that happens in a channel.

For further development I think that logging is almost a must. Because with that, we'll take bot to another level.

[matejvelikonja]

Another thing. The current JOIN listener should be better name. Maybe GreetOnJoinListener.

[super3]

Yeah it conflicts with the join command. I think just Greet will do.

On Wed, Jan 16, 2013 at 5:52 AM, Matej Velikonja
notifications@github.comwrote:

Another thing. The current JOIN listener should be better name. Maybe
GreetOnJoinListener.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-12313335.

Shawn Wilkinson
Student, Morehouse College
Independent Web Developer
me@super3.org
http://super3.org