Crashes if I add my view to UIWindow before recording snapshot

[tahirmt]

Describe the bug
If I try to run a snapshot test for a view controller but by adding it into a window myself, it causes a crash

To Reproduce

// And/or enter code that reproduces the behavior here.
import SnapshotTesting
import XCTest

class MyViewControllerTests: XCTestCase {
    func testMyViewController() {
        let vc = UIViewController()
        let window = UIWindow()
        window.rootViewController = vc
        window.isHidden = false

        assertSnapshot(matching: window, as: .image)
    }
}

Expected behavior
The window should be recorded as any other view does

Environment

• swift-snapshot-testing version 1.9.0
• Xcode 13.2.1
• Swift 5.5
• OS: iOS 15

Additional context

This is the console messages

Newly-taken snapshot does not match reference.
Test Case '-[snapshottoeventuallyTests.MyViewControllerTests testMyViewController]' failed (1.089 seconds).
Test Suite 'MyViewControllerTests' failed at 2022-03-30 15:23:21.256.
	 Executed 1 test, with 1 failure (0 unexpected) in 1.089 (1.090) seconds
Test Suite 'snapshottoeventuallyTests.xctest' failed at 2022-03-30 15:23:21.257.
	 Executed 2 tests, with 1 failure (0 unexpected) in 1.107 (1.114) seconds
Test Suite 'All tests' failed at 2022-03-30 15:23:21.258.
	 Executed 2 tests, with 1 failure (0 unexpected) in 1.107 (1.119) seconds
2022-03-30 15:23:21.262036-0400 snapshottoeventually[86546:2233788] *** -[UIWindowLayer isHidden]: message sent to deallocated instance 0x6040004b1210

[carlos-chaguendo]

in my case I have been able to solve it:

func testMyViewController() {
        let vc = UIViewController()
        let window = UIWindow()
        window.rootViewController = vc
        window.isHidden = false

        let container = UIViewController()
        container.view =  window

        assertSnapshot(matching: container, as: .image)
}

[tahirmt]

This is no longer an issue. Verified with 1.17.5 Never mind it is still an issue when using an Xcode project and app host

[mbrandonw]

Hi @tahirmt, windows are treated specially in UIKit and I'm not sure we can come up with a full-proof way to screenshot them. At the very least you should probably invoke makeKeyAndVisible on the window, but not sure if there is more you need to do.

Since I'm not sure this is really an issue with the library I am going to convert it to a discussion. Please feel free to continue the conversation over there!