Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17.0 doesn't compile on Xcode 16 Beta 3 #868

Closed
cameroncooke opened this issue Jul 9, 2024 · 1 comment · Fixed by #869
Closed

1.17.0 doesn't compile on Xcode 16 Beta 3 #868

cameroncooke opened this issue Jul 9, 2024 · 1 comment · Fixed by #869

Comments

@cameroncooke
Copy link

cameroncooke commented Jul 9, 2024

Describe the bug
The library doesn't compile on Xcode 16 Beta 3 due to a change in the swift-testing Issue.record() function arguments. Specially the error is: Extra arguments at positions #2, #3 in call

The Issue.record() function uses sourceLocation instead of filePath and line. It looks like we have to construct an instance of SourceLocation and provide in addition to filePath and line also column and fileID the latter can be created using fileID() function so it looks like the recordIssue() function of swift-testing will need some changes to pass in an existing SourceLocation or fileID

To Reproduce
Open project in Xcode 16 beta 3 and compile.

Expected behavior
Compiles ;-)

Screenshots

Screenshot 2024-07-09 at 13 24 24

Environment

  • swift-snapshot-testing version 1.17.0
  • Xcode 16.0 beta 3 (16A5202i)
  • Swift 6.0
  • OS: 15.0 Beta (24A5279h)
@cameroncooke
Copy link
Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant