Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add excerpt field to Elementor page settings #2837

Merged
merged 2 commits into from
Nov 28, 2017
Merged

Add excerpt field to Elementor page settings #2837

merged 2 commits into from
Nov 28, 2017

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Nov 27, 2017 •
edited
Loading

Related: #1579 (Enhancing the "Page Setting" panel)

page-settings-excerpt

@arielk
Copy link
Member

arielk commented Nov 27, 2017

Thanks @ramiy

But you need to check if the current CPT is support excerpt parameter

@ramiy
Copy link
Contributor Author

ramiy commented Nov 27, 2017

@arielk Done.

Tested on Pages that don't support excerpts. And then add excerpt support with Page Excerpt Plugin.

@ramiy
Copy link
Contributor Author

ramiy commented Nov 28, 2017

The PR hides the excerpt field when the post type has no excerpt support. But I think that it would be better to display the excerpt field and mark it with disabled attribute (see #1571).

@KingYes
Copy link
Member

KingYes commented Nov 28, 2017

@arielk Nice catch!

Thanks @ramiy

@KingYes KingYes merged commit 650da01 into elementor:release/1.9.0 Nov 28, 2017
@ramiy ramiy deleted the page-settings-excerpt branch November 28, 2017 12:54
@bainternet bainternet mentioned this pull request Jan 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramiy @arielk @KingYes